Fix SSH remoting test to work on all platforms#11500
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Jan 7, 2020
PaulHigin:fix-ssh-tests
Merged
Fix SSH remoting test to work on all platforms#11500adityapatwardhan merged 1 commit intoPowerShell:masterfrom PaulHigin:fix-ssh-tests
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
PaulHigin:fix-ssh-tests
Conversation
PoshChan
reviewed
Jan 6, 2020
Member
|
@PoshChan please rebuild all |
Collaborator
|
@adityapatwardhan, successfully started rebuild of |
14 tasks
adityapatwardhan
approved these changes
Jan 7, 2020
daxian-dbw
pushed a commit
that referenced
this pull request
Jan 10, 2020
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
One SSH remoting test was failing on some platforms because the returned error id string is slightly different.
PR Context
Depending on platform and error path the returned error id string can be '2100,PSSessionOpenFailed' or 'PSSessionOpenFailed'.
Fix is to update test to just look for the expected 'PSSessionOpenFailed'.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.