Replace use of throw GetExceptionForHR with ThrowExceptionForHR#11640
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Jan 31, 2020
Merged
Replace use of throw GetExceptionForHR with ThrowExceptionForHR#11640iSazonov merged 1 commit intoPowerShell:masterfrom
iSazonov merged 1 commit intoPowerShell:masterfrom
Conversation
`System.Runtime.InteropServices.Marshall.GetExceptionForHR` may not return an exception. Instead of `throw GetExceptionForHR` we can use `ThrowExceptionForHR`. Fix warnings `CS8597:Thrown value may be null.`
8 tasks
iSazonov
approved these changes
Jan 21, 2020
Contributor
Author
|
@daxian-dbw please review :) |
daxian-dbw
approved these changes
Jan 30, 2020
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
System.Runtime.InteropServices.Marshall.GetExceptionForHRmay not return an exception. Instead ofthrow GetExceptionForHRwe can useThrowExceptionForHR.PR Context
Fix warnings
CS8597:Thrown value may be null.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.