Change regex to match relation-types w/o quotes in Link header#11711
Merged
TravisEz13 merged 5 commits intoPowerShell:masterfrom Jan 31, 2020
Merged
Change regex to match relation-types w/o quotes in Link header#11711TravisEz13 merged 5 commits intoPowerShell:masterfrom
TravisEz13 merged 5 commits intoPowerShell:masterfrom
Conversation
iSazonov
approved these changes
Jan 29, 2020
iSazonov
reviewed
Jan 29, 2020
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
Outdated
Show resolved
Hide resolved
TravisEz13
previously requested changes
Jan 29, 2020
Member
TravisEz13
left a comment
There was a problem hiding this comment.
Please fix tests failures and address @iSazonov 's comments
iSazonov
approved these changes
Jan 30, 2020
Member
|
It would be good to add a tests to make sure this doesn't regress |
Collaborator
|
@TravisEz13 I do not find how we could add the test. We use AspNetCore for test and AspNetCore sends the header as-is. |
Member
|
@iSazonov Thanks for the explanation. |
Collaborator
|
@Marusyk Thanks for your contribution. |
Contributor
Author
|
Thanks for review and help |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change regex to match relation-types without quotes in Link header.
PR Context
Fixes #11629
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.Please review,
Thank you in advance