Fix help function to check if less is available before using#11737
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Feb 3, 2020
Merged
Fix help function to check if less is available before using#11737TravisEz13 merged 2 commits intoPowerShell:masterfrom
help function to check if less is available before using#11737TravisEz13 merged 2 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Jan 31, 2020
a7937b0 to
f5a1c5f
Compare
iSazonov
approved these changes
Feb 3, 2020
TravisEz13
approved these changes
Feb 3, 2020
Member
|
Should we continue to include less in the docker images? |
Member
Author
|
@TravisEz13 I would think most use of docker images are non-interactive, so |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
helpfunction assumes on non-Windows thatlessis available as a pager. However, on some Linux systems,lessis not installed by default so usinghelpfails thatlessis not found. FIx is to check iflessis available before using and, if not, just output the help text instead of paging.PR Context
Fix #9830
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.