Use new string.Split() overloads#11867
Merged
iSazonov merged 3 commits intoPowerShell:masterfrom Mar 13, 2020
Merged
Conversation
rjmholt
reviewed
Feb 18, 2020
Collaborator
There was a problem hiding this comment.
Is this a LINQ usage now? I think it's probably best to keep it as a string
Collaborator
There was a problem hiding this comment.
But if it's not LINQ, then no issues
Collaborator
Author
There was a problem hiding this comment.
No, it is String method:
public bool Contains(char value);
Collaborator
There was a problem hiding this comment.
Might be worth labelling the 2 parameter
SteveL-MSFT
requested changes
Feb 19, 2020
Member
There was a problem hiding this comment.
Seems like this can be just reduced to .Trim('"')?
Member
There was a problem hiding this comment.
Suggested change
| object[] modulesToImport = optionValue.Split(",", StringSplitOptions.RemoveEmptyEntries); | |
| object[] modulesToImport = optionValue.Split(',', StringSplitOptions.RemoveEmptyEntries); |
PoshChan
reviewed
Feb 20, 2020
Collaborator
Author
|
@PoshChan Please retry linux |
Collaborator
|
@iSazonov, successfully started retry of |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Use new String.Split overlods to remove extra allocations.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.