Fix ModuleInfoGrouping format#11950
Conversation
|
@ThomasNieto #11927 and #7856 is issues with conclusions. It seems the PR fixes only #7856. |
|
@iSazonov the newest commit adds logic for modules in |
|
I'd expect that core modules is fixed in its manifests. |
|
@iSazonov have any idea why CodeFactor failed? How do I get it to retry? |
|
CodeFactor CI is not mandatory. We use it as temporary recommendations. |
| { | ||
| $editions = @(($_.PrivateData.PSData.Tags | Where-Object {$_ -like 'PSEdition_*'}) -replace 'PSEdition_', '') | ||
| } | ||
| elseif ($_.ModuleBase -like '{0}*' -f $PSHOME) { |
There was a problem hiding this comment.
| elseif ($_.ModuleBase -like '{0}*' -f $PSHOME) { | |
| elseif ($_.ModuleBase -like ""$PSHOME*"") { |
| $editions = @('Core') | ||
| } | ||
| elseif ($IsWindows -and | ||
| $_.ModuleBase -like '{0}\Windows\system32\WindowsPowerShell\v1.0\Modules' -f $Env:SystemDrive ) { |
There was a problem hiding this comment.
| $_.ModuleBase -like '{0}\Windows\system32\WindowsPowerShell\v1.0\Modules' -f $Env:SystemDrive ) { | |
| $_.ModuleBase -like ""$Env:SystemDrive\Windows\system32\WindowsPowerShell\v1.0\Modules"") { |
|
The changes in this PR conflicts with the effort in #11943, which tries to make the module formatting script work in strict mode. |
|
@ThomasNieto Could you please address latest comments? |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
TravisEz13
left a comment
There was a problem hiding this comment.
Please address @daxian-dbw comments
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
PR Summary
This PR updates the
PSEditioncolumn in theModuletable format to checkPrivateData.PSData.TagsforPSEdition_DesktopandPSEdition_CoreifCompatiblePSEditionsis not defined. This allows module authors to indicate compatiblePSEditionswithout limiting module compatibility to 5.1+ by usingCompatiblePSEditions.If
CompatiblePSEditionsor tags are not for a module in $PSHOME it will addCoreand if the module is in Windows in-box it will addDesktop.PR Context
This PR fixes #11927 and #7856
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.