Ignore last exit code in the build step as dotnet may return error when SDK is not installed#11972
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Feb 28, 2020
Merged
Conversation
…en sdk is not installed
daxian-dbw
approved these changes
Feb 28, 2020
SteveL-MSFT
approved these changes
Feb 28, 2020
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
NIT: since we have this in 3 places, should consider have it as a helper function, but not necessary for this PR
Member
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@daxian-dbw, this is the reminder you requested 1 hour ago |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When
dotnetversion installed does not match the version in global.json,dotnetmay set a error exit code. Az DevOps has started failing when that happens. The PR addresses that by ignoring the last exit code.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.