Skip to content

Ignore last exit code in the build step as dotnet may return error when SDK is not installed#11972

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:FixBuildLastExitcode
Feb 28, 2020
Merged

Ignore last exit code in the build step as dotnet may return error when SDK is not installed#11972
daxian-dbw merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:FixBuildLastExitcode

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Feb 28, 2020

PR Summary

When dotnet version installed does not match the version in global.json, dotnet may set a error exit code. Az DevOps has started failing when that happens. The PR addresses that by ignoring the last exit code.

PR Context

PR Checklist

Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: since we have this in 3 places, should consider have it as a helper function, but not necessary for this PR

@daxian-dbw
Copy link
Copy Markdown
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Copy Markdown
Collaborator

@daxian-dbw, this is the reminder you requested 1 hour ago

@daxian-dbw daxian-dbw merged commit 91c9be9 into PowerShell:master Feb 28, 2020
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 24, 2020
@adityapatwardhan adityapatwardhan added this to the 7.1.0-preview.1 milestone Mar 24, 2020
@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@adityapatwardhan adityapatwardhan deleted the FixBuildLastExitcode branch June 8, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants