Skip to content

Update LICENSE to remove version of PowerShell#12019

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
SteveL-MSFT:update-license
Mar 13, 2020
Merged

Update LICENSE to remove version of PowerShell#12019
daxian-dbw merged 2 commits intoPowerShell:masterfrom
SteveL-MSFT:update-license

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Mar 5, 2020 •
edited
Loading

PR Summary

Unfortunately, we shipped 7.0 with a License that explicitly calls out 6.0. I'm following up with legal if we can just remove the version altogether.

PR Checklist

@SteveL-MSFT SteveL-MSFT added this to the 7.0.x-Servicing-Consider milestone Mar 5, 2020
@SteveL-MSFT SteveL-MSFT requested a review from TravisEz13 March 5, 2020 00:50
PoshChan
PoshChan reviewed Mar 5, 2020
View reviewed changes
PoshChan
PoshChan reviewed Mar 5, 2020
View reviewed changes
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Mar 5, 2020

Unfortunately, we shipped 7.0 with a License that explicitly calls out 6.0.

Perhaps MSFT could make the release branch public before release so that community could review.

@SteveL-MSFT
Copy link
Copy Markdown
Member Author

SteveL-MSFT commented Mar 5, 2020

@iSazonov we should have caught this when we updated across the source code from 6 to 7. Compliance for building/signing the release means we can't make that public, but it's essentially the same as on GitHub just minor fixes when needed which get pushed back to GitHub anyways. Got confirmation we can leave off the version number, so will update.

PoshChan
PoshChan reviewed Mar 5, 2020
View reviewed changes
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Mar 5, 2020 •
edited by unfurl-links bot
Loading

https://shell.azure.com/ fail in Static CI in last days. (But I can open locally)

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Mar 13, 2020

@PoshChan please retry static

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Mar 13, 2020

@daxian-dbw, successfully started retry of PowerShell-CI-static-analysis

@daxian-dbw daxian-dbw merged commit e9152a5 into PowerShell:master Mar 13, 2020
@SteveL-MSFT SteveL-MSFT changed the title Update LICENSE to reflect version of PowerShell Update LICENSE to remove version of PowerShell Mar 16, 2020
@SteveL-MSFT SteveL-MSFT deleted the update-license branch March 16, 2020 17:08
@adityapatwardhan adityapatwardhan added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Mar 24, 2020
@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 modified the milestones: 7.0.1-approved, 7.0.1 Apr 20, 2020
@ghost
Copy link
Copy Markdown

ghost commented May 14, 2020

🎉v7.0.1 has been released which incorporates this pull request.:tada:

Handy links:

silijon pushed a commit to SkyKick/PowerShell that referenced this pull request Jul 2, 2020
@SteveL-MSFT @TravisEz13
Remove the version number of PowerShell from LICENSE (PowerShell#12019)
9873602
@thecliguy thecliguy mentioned this pull request Oct 13, 2020
Closed
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

7.0.1

Development

Successfully merging this pull request may close these issues.

6 participants

@SteveL-MSFT @iSazonov @daxian-dbw @PoshChan @TravisEz13 @adityapatwardhan