Encoding Parameter for Tee-Object by Peter-Schneider · Pull Request #12135 · PowerShell/PowerShell

Peter-Schneider · 2020-03-16T18:51:09Z

PR Summary

Adds an Encoding parameter to the Tee-Object cmdlet (See issue #11104)

PR Context

PR Checklist

src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs

vexx32 · 2020-03-16T19:16:27Z

Ha, you beat me to it. 😁

src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs

Peter-Schneider · 2020-03-17T10:13:15Z

@vexx32 Thank you anyway.. ;-)

iSazonov · 2020-03-17T11:41:36Z

@Peter-Schneider Please add tests.

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1

src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs

iSazonov · 2020-03-20T03:15:22Z

@Peter-Schneider Please open new issue in PowerShell-Docs repo for the new parameter and add reference in the PR description.

iSazonov · 2020-03-20T08:09:54Z

@SteveL-MSFT @TravisEz13 Could you please look CI failures? It seems it is not the PR related.

TravisEz13 · 2020-03-20T15:28:41Z

@iSazonov The windows failure definitely seem related to this branch. Perhaps a rebase is needed.

iSazonov · 2020-03-20T15:31:41Z

@Peter-Schneider Please rebase. You will be switched to new .Net version - 5.0 Preview1, so you should install it.

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1

…All Pester block

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1

Co-Authored-By: Ilya <[email protected]>

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1

ghost · 2020-06-10T02:00:23Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

iSazonov · 2020-06-11T11:37:40Z

@TravisEz13 @SteveL-MSFT Could you please review the PR.

ghost · 2020-06-18T14:00:26Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

iSazonov · 2020-07-22T14:01:08Z

Reopen to update CIs.

ghost · 2020-07-30T02:00:29Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

iSazonov · 2021-01-09T07:24:43Z

@SteveL-MSFT Can we merge?

ghost · 2021-01-16T14:00:10Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

SteveL-MSFT · 2021-07-21T20:39:32Z

@iSazonov I think this is good to go. thanks.

iSazonov · 2021-07-22T04:28:11Z

@Peter-Schneider Thanks for your contribution!

Peter-Schneider · 2021-07-22T06:24:57Z

Thanks for merging! 🥳

ghost · 2021-08-23T18:36:47Z

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost · 2021-09-28T23:18:37Z

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost assigned iSazonov Mar 16, 2020

vexx32 suggested changes Mar 16, 2020

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020

vexx32 approved these changes Mar 16, 2020

View reviewed changes

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020

christian7877 suggested changes Mar 16, 2020

View reviewed changes

src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated Show resolved Hide resolved

src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated Show resolved Hide resolved

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 17, 2020

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 17, 2020

iSazonov added this to the 7.1.0-preview.1 milestone Mar 17, 2020

iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Mar 17, 2020

iSazonov reviewed Mar 18, 2020

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated Show resolved Hide resolved

iSazonov reviewed Mar 18, 2020

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated Show resolved Hide resolved

iSazonov reviewed Mar 19, 2020

View reviewed changes

src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated Show resolved Hide resolved

Peter-Schneider mentioned this pull request Mar 20, 2020

Add documentation for Tee-Object -Encoding Parameter MicrosoftDocs/PowerShell-Docs#5612

Closed

11 tasks

iSazonov reviewed Mar 21, 2020

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated Show resolved Hide resolved

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated Show resolved Hide resolved

Use Pester special drive for temp files and remove testfile in Before…

b56f7c0

…All Pester block

iSazonov reviewed Mar 21, 2020

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated Show resolved Hide resolved

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated Show resolved Hide resolved

Peter-Schneider and others added 2 commits March 21, 2020 17:14

Delte testfile in BeforeEach Pester block

b08faa4

Fix CI

3af62f4

Co-Authored-By: Ilya <[email protected]>

iSazonov reviewed Mar 22, 2020

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated Show resolved Hide resolved

Changed testValue to ф

bace4cb

Address CI failure

9ce687b

TravisEz13 removed the Review - Needed The PR is being reviewed label Jun 2, 2020

ghost added the Review - Needed The PR is being reviewed label Jun 10, 2020

ghost removed the Review - Needed The PR is being reviewed label Jun 11, 2020

ghost added the Review - Needed The PR is being reviewed label Jun 18, 2020

adityapatwardhan removed this from the 7.1.0-preview.4 milestone Jun 29, 2020

iSazonov closed this Jul 22, 2020

ghost removed the Review - Needed The PR is being reviewed label Jul 22, 2020

iSazonov reopened this Jul 22, 2020

ghost added the Review - Needed The PR is being reviewed label Jul 30, 2020

ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021

ghost added the Review - Needed The PR is being reviewed label Jan 16, 2021

ghost removed the Review - Needed The PR is being reviewed label Jul 21, 2021

SteveL-MSFT closed this Jul 21, 2021

SteveL-MSFT reopened this Jul 21, 2021

iSazonov merged commit de5dc63 into PowerShell:master Jul 22, 2021

iSazonov added this to the 7.2.0-preview.8 milestone Jul 22, 2021

Conversation

Peter-Schneider commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vexx32 commented Mar 16, 2020

Uh oh!

Uh oh!

Uh oh!

Peter-Schneider commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Mar 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iSazonov commented Mar 20, 2020

Uh oh!

iSazonov commented Mar 20, 2020

Uh oh!

TravisEz13 commented Mar 20, 2020

Uh oh!

iSazonov commented Mar 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jun 10, 2020

Uh oh!

iSazonov commented Jun 11, 2020

Uh oh!

ghost commented Jun 18, 2020

Uh oh!

iSazonov commented Jul 22, 2020

Uh oh!

ghost commented Jul 30, 2020

Uh oh!

iSazonov commented Jan 9, 2021

Uh oh!

ghost commented Jan 16, 2021

Uh oh!

SteveL-MSFT commented Jul 21, 2021

Uh oh!

iSazonov commented Jul 22, 2021

Uh oh!

Peter-Schneider commented Jul 22, 2021

Uh oh!

ghost commented Aug 23, 2021

Uh oh!

ghost commented Sep 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Peter-Schneider commented Mar 16, 2020 •

edited

Loading

Peter-Schneider commented Mar 17, 2020 •

edited

Loading

iSazonov commented Mar 20, 2020 •

edited

Loading