Upgrade to .NET 5 Preview 2#12250
Merged
adityapatwardhan merged 8 commits intoPowerShell:masterfrom Apr 8, 2020
Merged
Conversation
Collaborator
|
@bergmeister You don't update all places. See #12140. |
added 2 commits
April 7, 2020 14:20
…via output of Start-PSPacakge again)" This reverts commit 0ae6b3d.
Collaborator
|
@bergmeister Please add in EndProcessing() method of the Send-MailMessage cmdlet. |
Contributor
Author
|
Good point, I could locally repro and fix it with that. I will add it in a finally block and bring an existing disposal into that finally block as well |
…ssing in a finally block and include another disposal in there as well.
iSazonov
approved these changes
Apr 7, 2020
SteveL-MSFT
approved these changes
Apr 7, 2020
Member
|
@bergmeister can you fix the CodeFactor issue? |
Contributor
Author
|
@SteveL-MSFT OK, done. |
Contributor
Author
|
@PoshChan Rerun Mac |
Collaborator
|
@bergmeister, I do not understand the build target(s) |
Contributor
Author
|
@PoshChan Rerun macos |
Collaborator
|
@bergmeister, successfully started rebuild of |
TravisEz13
approved these changes
Apr 7, 2020
adityapatwardhan
approved these changes
Apr 8, 2020
Collaborator
|
@bergmeister Thanks! |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Note: The
files.wxswas updated with the suggested file fromStart-PSPackage.The change in Send-MailMessage was due to test failures and probably due to this bug fix in .Net Core: dotnet/runtime#683
PR Context
https://devblogs.microsoft.com/dotnet/announcing-net-5-0-preview-2/
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.