Compare-Object Apply -IncludeEqual when -ExcludeDifferent is specified#12317
Compare-Object Apply -IncludeEqual when -ExcludeDifferent is specified#12317TravisEz13 merged 4 commits intoPowerShell:masterfrom
Conversation
|
I would like input from the maintainers on whether they think an experimental feature is required in this case. I can't think of a use case where anyone would use -ExcludeDifferent without wanting to see the objects that are equal, but I can see where it could still technically be a breaking change. |
|
@PowerShell/powershell-committee Can your review and see if we want to take this change, if it should be experimental, and if we should call it breaking? I think it should be experimental. I think this is breaking change, bucket 2. I think someone could have reasonably taken a decency on this, but I think the new behavior is predictable and obvious. |
|
/cc @mklement0 |
|
One of the macos failures doesn't look random. You may need to rebase. Tell me if you need me to do that for you. |
|
@PowerShell/powershell-committee reviewed this. We agree that the original intent is that |
|
@davidseibel I rebased your branch to see if it resolved the failure. Be sure to pull the changes, before making any additional changes. |
|
@PoshChan Please remind me in 1 hour |
|
@TravisEz13 - thanks, sorry for the slow response on my part. For my own benefit, would you mind explaining how you rebased? Still learning here... |
|
@TravisEz13, this is the reminder you requested 1 hour ago |
|
@davidseibel probably safest to do a Check |
|
@davidseibel Thanks for your contribution! |
|
🎉 Handy links: |
PR Summary
Fixes #11847
PR Context
This pull request corrects the following behavior specified in issue #11847: when Compare-Object is used with the -ExcludeDifferent switch, the -IncludeEqual switch is not inferred.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.