Disable PublishReadyToRun for framework dependent packages#12450
Disable PublishReadyToRun for framework dependent packages#12450TravisEz13 merged 2 commits intoPowerShell:masterfrom
PublishReadyToRun for framework dependent packages#12450Conversation
iSazonov
left a comment
There was a problem hiding this comment.
I wonder why packaging test passed previously.
|
@iSazonov I believe we do not build fxdependent packages in CI. |
|
@PoshChan please retry static, windows |
|
@adityapatwardhan, successfully started retry of |
| @@ -391,6 +391,13 @@ Fix steps: | |||
| $Arguments += "/property:IsWindows=false" | |||
There was a problem hiding this comment.
@adityapatwardhan, your last commit had 10 failures in PowerShell-CI-static-analysis
(These are 5 of the failures)
Verify Markdown Links.Verify links in /home/vsts/work/1/s/README.md.https://blogs.msdn.microsoft.com/powershell/2017/01/31/powershell-open-source-community-dashboard/ should work
Connection timed out
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 114
114: $null = Invoke-WebRequest -uri $url -RetryIntervalSec 10 -MaximumRetryCount 6
Verify Markdown Links.Verify links in /home/vsts/work/1/s/README.md.https://blogs.msdn.microsoft.com/powershell/2017/01/31/powershell-open-source-community-dashboard/ should work
Failed to complete request to "https://blogs.msdn.microsoft.com/powershell/2017/01/31/powershell-open-source-community-dashboard/". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119: throw "Failed to complete request to `"$url`". $($_.Exception.Message)"
Verify Markdown Links.Verify links in /home/vsts/work/1/s/demos/WindowsPowerShellModules/README.md.https://blogs.msdn.microsoft.com/powershell/2017/07/14/powershell-6-0-roadmap-coreclr-backwards-compatibility-and-more/ should work
Failed to complete request to "https://blogs.msdn.microsoft.com/powershell/2017/07/14/powershell-6-0-roadmap-coreclr-backwards-compatibility-and-more/". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119: throw "Failed to complete request to `"$url`". $($_.Exception.Message)"
Verify Markdown Links.Verify links in /home/vsts/work/1/s/demos/WindowsPowerShellModules/README.md.https://blogs.msdn.microsoft.com/powershell/2017/07/14/powershell-6-0-roadmap-coreclr-backwards-compatibility-and-more/ should work
Failed to complete request to "https://blogs.msdn.microsoft.com/powershell/2017/07/14/powershell-6-0-roadmap-coreclr-backwards-compatibility-and-more/". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119: throw "Failed to complete request to `"$url`". $($_.Exception.Message)"
Verify Markdown Links.Verify links in /home/vsts/work/1/s/CHANGELOG/6.0.md.https://blogs.msdn.microsoft.com/powershell/2017/07/14/powershell-6-0-roadmap-coreclr-backwards-compatibility-and-more/ should work
Failed to complete request to "https://blogs.msdn.microsoft.com/powershell/2017/07/14/powershell-6-0-roadmap-coreclr-backwards-compatibility-and-more/". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119: throw "Failed to complete request to `"$url`". $($_.Exception.Message)"
|
@PoshChan please retry static |
|
@adityapatwardhan, successfully started retry of |
|
@TravisEz13 Ready to merge? |
|
🎉 Handy links: |
|
Actually Framework Dependent builds DO support ReadyToRun. Just specify both rid and Personally I always have the latest .net SDK installed, so I don't want to use the self contained release. It would be better in my case to use a |
|
@imba-tjd Please open new issue with you feedback. Thanks! |
PR Summary
PublishReadyToRun is not supported for a framework dependent package as it needs a runtime to be specified. This PR disables ReadyToRun by overriding the setting Powershell.Common.prop.
PR Context
Fix package build failure introduced by #12361
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.