Skip to content

Sign the MSIX files for the store#12582

Merged
TravisEz13 merged 15 commits intoPowerShell:masterfrom
TravisEz13:sign-msix
May 29, 2020
Merged

Sign the MSIX files for the store#12582
TravisEz13 merged 15 commits intoPowerShell:masterfrom
TravisEz13:sign-msix

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented May 5, 2020 •
edited
Loading

PR Summary

Sign the MSIX files for the store

PR Context

PR Checklist

@ghost ghost assigned anmenaga May 5, 2020
adityapatwardhan
adityapatwardhan requested changes May 5, 2020
View reviewed changes
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 5, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 5, 2020
@TravisEz13 TravisEz13 mentioned this pull request May 17, 2020
Open
@ghost ghost added the Review - Needed The PR is being reviewed label May 27, 2020
@ghost
Copy link
Copy Markdown

ghost commented May 27, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@TravisEz13 TravisEz13 removed the Review - Needed The PR is being reviewed label May 27, 2020
@TravisEz13 TravisEz13 marked this pull request as ready for review May 29, 2020 00:58
@TravisEz13 TravisEz13 merged commit 2fe3499 into PowerShell:master May 29, 2020
@TravisEz13 TravisEz13 deleted the sign-msix branch May 29, 2020 17:26
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label May 29, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.4 milestone May 29, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

TravisEz13 added a commit that referenced this pull request Sep 9, 2020
@TravisEz13 @adityapatwardhan
Sign the MSIX files for the store (#12582)
41622a6 
Co-authored-by: Aditya Patwardhan <[email protected]>
# Conflicts:
#	tools/releaseBuild/setReleaseTag.ps1
@ghost
Copy link
Copy Markdown

ghost commented Jan 19, 2021

🎉v7.0.4 has been released which incorporates this pull request.:tada:

Handy links:

@XVII
Copy link
Copy Markdown

XVII commented Apr 12, 2021

@TravisEz13 , still getting issues with PowerShell in Store-published apps.
The system cannot find the file specified Microsoft.Management.Infrastructure.dll.

I can see the runtime in the app release folder, but the UWP packaging doesn't seem to pick it up and bundle it into the store package before submission: (i.e. win10-x64\lib\netstandard1.6\Microsoft.Management.Infrastructure.dll)

image

Not to sure if this is the best repo for this issue or whether it's more related to PowerShell/MMI#45.

@TravisEz13
Copy link
Copy Markdown
Member Author

TravisEz13 commented Apr 12, 2021 •
edited
Loading

@ShadowXVII Are you saying this is because it's unsigned? Commenting on a closed issue isn't really a great idea unless you are sure it is related.

@XVII XVII mentioned this pull request Apr 13, 2021
Open
@XVII
Copy link
Copy Markdown

XVII commented Apr 13, 2021 •
edited
Loading

@TravisEz13, well no, but if it's working for others then I must be missing something in my configuration -- this was my blocker previously. I've created an issue in MMI to see if they can assist.

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@anmenaga anmenaga

Labels

Backport-7.0.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.4

Development

Successfully merging this pull request may close these issues.

5 participants

@TravisEz13 @XVII @SteveL-MSFT @adityapatwardhan @anmenaga