-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Update the PowerShell modules to use the new Help URI #12686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,5 +10,5 @@ FunctionsToExport = @() | |
| CmdletsToExport="Start-Transcript", "Stop-Transcript" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adityapatwardhan, your last commit had 30 failures in Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Host' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Management' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adityapatwardhan, your last commit had 48 failures in Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate 'Save-Help -DestinationPath for one PowerShell modules..Validate Save-Help for the 'Microsoft.PowerShell.Core' module Expected 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.cab', because Save-Help for should download 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.cab', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 333
333: $compressedFile | Should -Be $expectedCompressedFile -Because "Save-Help for $module should download '$expectedCompressedFile'"Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'CimCmdlets' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adityapatwardhan, your last commit had 50 failures in Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate 'Save-Help -DestinationPath for one PowerShell modules..Validate Save-Help for the 'Microsoft.PowerShell.Core' module Expected 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.cab', because Save-Help for should download 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.cab', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 333
333: $compressedFile | Should -Be $expectedCompressedFile -Because "Save-Help for $module should download '$expectedCompressedFile'"Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'CimCmdlets' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adityapatwardhan, your last commit had 42 failures in Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountNullCoalesceOperations.Null coalesce operator ??.Should only evaluate LHS once when it is NOT null Expected 1, but got 2.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Language/Operators/NullConditional.Tests.ps1: line 185
185: $testState.Value | Should -Be 1Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Host' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adityapatwardhan, your last commit had 45 failures in Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountNullCoalesceOperations.Null coalesce operator ??.Should only evaluate LHS once when it is NOT null Expected 1, but got 2.
at <ScriptBlock>, /Users/runner/runners/2.169.1/work/1/s/test/powershell/Language/Operators/NullConditional.Tests.ps1: line 185
185: $testState.Value | Should -Be 1Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Host' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adityapatwardhan, your last commit had 50 failures in Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate 'Save-Help -DestinationPath for one PowerShell modules..Validate Save-Help for the 'Microsoft.PowerShell.Core' module Expected 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.cab', because Save-Help for should download 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.cab', but got $null.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 333
333: $compressedFile | Should -Be $expectedCompressedFile -Because "Save-Help for $module should download '$expectedCompressedFile'"Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'CimCmdlets' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adityapatwardhan, your last commit had 42 failures in Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountNullCoalesceOperations.Null coalesce operator ??.Should only evaluate LHS once when it is NOT null Expected 1, but got 2.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Language/Operators/NullConditional.Tests.ps1: line 185
185: $testState.Value | Should -Be 1Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Host' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adityapatwardhan, your last commit had 45 failures in Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountNullCoalesceOperations.Null coalesce operator ??.Should only evaluate LHS once when it is NOT null Expected 1, but got 2.
at <ScriptBlock>, /Users/runner/runners/2.169.1/work/1/s/test/powershell/Language/Operators/NullConditional.Tests.ps1: line 185
185: $testState.Value | Should -Be 1Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.CountValidate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Host' with scope as 'False' Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.168.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181: $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count |
||
| AliasesToExport = @() | ||
| NestedModules="Microsoft.PowerShell.ConsoleHost.dll" | ||
| HelpInfoURI = 'https://go.microsoft.com/fwlink/?linkid=2113538' | ||
| HelpInfoURI = 'https://aka.ms/powershell71-help' | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -175,13 +175,13 @@ static UpdatableHelpCommandBase() | |||
|
|
||||
| // TODO: assign real TechNet addresses | ||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Delete the TODO comment - it is not accurate or needed anymore
Suggested change
|
||||
|
|
||||
| s_metadataCache.Add("Microsoft.PowerShell.Diagnostics", "https://go.microsoft.com/fwlink/?linkid=2113532"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Core", "https://go.microsoft.com/fwlink/?linkid=2113534"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Utility", "https://go.microsoft.com/fwlink/?linkid=2113633"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Host", "https://go.microsoft.com/fwlink/?linkid=2113538"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Management", "https://go.microsoft.com/fwlink/?linkid=2113632"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Security", "https://go.microsoft.com/fwlink/?linkid=2113533"); | ||||
| s_metadataCache.Add("Microsoft.WSMan.Management", "https://go.microsoft.com/fwlink/?linkid=2113537"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Diagnostics", "https://aka.ms/powershell71-help"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Core", "https://aka.ms/powershell71-help"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Utility", "https://aka.ms/powershell71-help"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Host", "https://aka.ms/powershell71-help"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Management", "https://aka.ms/powershell71-help"); | ||||
| s_metadataCache.Add("Microsoft.PowerShell.Security", "https://aka.ms/powershell71-help"); | ||||
| s_metadataCache.Add("Microsoft.WSMan.Management", "https://aka.ms/powershell71-help"); | ||||
| } | ||||
|
|
||||
| /// <summary> | ||||
|
|
||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityapatwardhan, your last commit had 30 failures in
PowerShell-CI-linux(These are 5 of the failures)
Validate Update-Help from the Web for one PowerShell module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False'
Validate Update-Help from the Web for one PowerShell module for user scope..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False'
Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False'
Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Host' with scope as 'False'
Validate Update-Help from the Web for all PowerShell modules..Validate Update-Help for module 'Microsoft.PowerShell.Management' with scope as 'False'