Skip to content

Nullable annotations for CommandSearcher #12733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
May 21, 2020
Merged

Nullable annotations for CommandSearcher #12733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ef79ac
Nullable annotations for CommandSearcher
powercode May 13, 2020
c5f7fb7
Addressing xtqqczze review comments
powercode May 20, 2020
24326d9
Addressing Ilya's review comments
powercode May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/System.Management.Automation/engine/CommandPathSearch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

#nullable enable

using System.Collections;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.IO;
using System.Linq;

#nullable enable

namespace System.Management.Automation
{
/// <summary>
Expand All @@ -18,7 +18,7 @@ namespace System.Management.Automation
internal class CommandPathSearch : IEnumerable<string>, IEnumerator<string>
{
[TraceSource("CommandSearch", "CommandSearch")]
private static PSTraceSource s_tracer = PSTraceSource.GetTracer("CommandSearch", "CommandSearch");
private static readonly PSTraceSource s_tracer = PSTraceSource.GetTracer("CommandSearch", "CommandSearch");

/// <summary>
/// Constructs a command searching enumerator that resolves the location
Expand All @@ -44,7 +44,7 @@ internal CommandPathSearch(
string commandName,
LookupPathCollection lookupPaths,
ExecutionContext context,
Collection<string> acceptableCommandNames,
Collection<string>? acceptableCommandNames,
bool useFuzzyMatch)
{
_useFuzzyMatch = useFuzzyMatch;
Expand Down
Loading