Skip to content

Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.13#12772

Merged
daxian-dbw merged 1 commit intomasterfrom
dotnet_update
May 29, 2020
Merged

Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.13#12772
daxian-dbw merged 1 commit intomasterfrom
dotnet_update

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Automated changes by create-pull-request GitHub action

@ghost ghost assigned daxian-dbw May 24, 2020
@daxian-dbw
Copy link
Copy Markdown
Member

@PoshChan please retry static

@PoshChan
Copy link
Copy Markdown
Collaborator

@daxian-dbw, successfully started retry of PowerShell-CI-static-analysis

@daxian-dbw
Copy link
Copy Markdown
Member

@adityapatwardhan Can you please take a look? Nothing changed in files.wxs.

@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label May 26, 2020
@adityapatwardhan
Copy link
Copy Markdown
Member

It seems only the SDK version changed and no packages or runtime changes. I believe we can decide to not take this PR and wait for one which has other changes too.

@github-actions github-actions bot changed the title Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20272.9 Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20276.15 May 27, 2020
@adityapatwardhan
Copy link
Copy Markdown
Member

@daxian-dbw Let me verify that there are no changes other changes. Something does not seem right.

@adityapatwardhan
Copy link
Copy Markdown
Member

@daxian-dbw there is actually no change to dependency versions only the sdk version updated.

@github-actions github-actions bot changed the title Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20276.15 Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.1 May 28, 2020
@adityapatwardhan
Copy link
Copy Markdown
Member

@daxian-dbw I think this can be merged.

@github-actions github-actions bot changed the title Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.1 Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.13 May 29, 2020
@daxian-dbw daxian-dbw merged commit 99da109 into master May 29, 2020
@adityapatwardhan adityapatwardhan deleted the dotnet_update branch May 29, 2020 16:37
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.4 milestone May 29, 2020
ghost pushed a commit that referenced this pull request Jun 2, 2020
# PR Summary

* Increase the list capacity because .NET v5.0.100-preview.5.20278.13 has an extra assembly
* Remove assert added in #12520

## PR Context

HEAD of master has been broken since 99da109 (#12772), when .NET was updated to 5.0.100-preview.5.20278.13

#12815 (comment)

## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
    - [x] None
    - **OR**
    - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
        - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
    - [x] N/A or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
    - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    - **OR**
    - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
        - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
        - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
        - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
@ghost
Copy link
Copy Markdown

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants