Remove use of Test-Path in ConciseView#12778
Merged
iSazonov merged 6 commits intoPowerShell:masterfrom Jun 11, 2020
Merged
Conversation
PoshChan
reviewed
May 25, 2020
...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
May 25, 2020
...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
May 25, 2020
...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
Outdated
Show resolved
Hide resolved
vexx32
reviewed
May 25, 2020
...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
@SteveL-MSFT Please look CI failures. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Collaborator
|
@SteveL-MSFT Could you please fix CIs? |
909424e to
2f04318
Compare
2f04318 to
53ce2d9
Compare
vexx32
reviewed
Jun 6, 2020
iSazonov
reviewed
Jun 6, 2020
iSazonov
reviewed
Jun 6, 2020
|
Hello @iSazonov! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
iSazonov
approved these changes
Jun 6, 2020
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Both
ConciseViewandGet-ErrorusedTest-Pathwhich wouldn't be available if$PSModuleAutoLoadingPreferenceis set tonone. Fix is to simply check against$nullinstead of using that cmdlet.PR Context
Fix #12671
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.