Skip to content

Expand numberOfPowershellRefAssemblies list capacity #12840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from
Jun 2, 2020
Merged

Expand numberOfPowershellRefAssemblies list capacity #12840

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1642121
Expand numberOfPowershellRefAssemblies list capacity
xtqqczze May 29, 2020
370812d
Remove assert
xtqqczze May 29, 2020
aba4d03
Address @iSazonov review
xtqqczze Jun 1, 2020
558d794
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Add…
iSazonov Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,10 +671,9 @@ private void LoadAssemblies(IEnumerable<string> assemblies)
private static IEnumerable<PortableExecutableReference> InitDefaultRefAssemblies()
{
// Define number of reference assemblies distributed with PowerShell.
// This number is accurate as of PowerShell v7.1.0-preview.1 built with .NET v5.0.100-preview.1.20155.7
const int numberOfPowershellRefAssemblies = 151;
const int maxPowershellRefAssemblies = 160;

const int capacity = numberOfPowershellRefAssemblies + 1;
const int capacity = maxPowershellRefAssemblies + 1;
var defaultRefAssemblies = new List<PortableExecutableReference>(capacity);

foreach (string file in Directory.EnumerateFiles(s_netcoreAppRefFolder, "*.dll", SearchOption.TopDirectoryOnly))
Expand Down