Merged
Conversation
PoshChan
reviewed
Jun 4, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/Clipboard.Tests.ps1
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jun 4, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/Clipboard.Tests.ps1
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jun 4, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/Clipboard.Tests.ps1
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Jun 4, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/Clipboard.Tests.ps1
Outdated
Show resolved
Hide resolved
TravisEz13
approved these changes
Jun 4, 2020
Member
|
Please investigate test failures |
Collaborator
Author
|
@TravisEz13 two tests fail in Get-Process.Tests.ps1 - I did not find when we ruined it and how to fix it. |
baed45e to
663cc5c
Compare
PoshChan
reviewed
Jun 4, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/Clipboard.Tests.ps1
Outdated
Show resolved
Hide resolved
Member
|
@PoshChan please rerun windows |
Collaborator
|
@TravisEz13, successfully started rebuild of |
Member
|
/azp help |
This comment has been minimized.
This comment has been minimized.
Member
|
/azp run powershell-ci-macos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run powershell-ci-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pending two Linux tests
62f7a5d to
17ecd02
Compare
Collaborator
Author
|
@TravisEz13 @SteveL-MSFT I found why Linux tests fail. It is dotnet/runtime#33673. |
17ecd02 to
5347689
Compare
5347689 to
1da45b3
Compare
Member
|
Please file an issue to track re-enabling the tests. |
|
I have found a solution to #12908. I would like to contribute. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
$PSDefaultParameterValueswith$global:PSDefaultParameterValuesto correctly restore skipping settings.(PowerShell process name is
ConsoleHost maiinstead ofpwsh)PowerShell/src/System.Management.Automation/CoreCLR/CorePsPlatform.cs
Lines 972 to 985 in 5ef69e8
Since a process names contains a space (
ConsoleHost mai) the split returns additional extra element and we get wrong value withparts[3].PR Context
I discovered that CIs skip silently many tests which run after the Clipboard tests.
I have more general concern - I saw that tests was skipped on Linux but not on Windows and MacOS and I don't understand how this can be. My concern is that there is a bug. I hope MSFT can investigate this.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.