Add HoloLens to list of PowerShell adopters#12940
Merged
iSazonov merged 4 commits intoPowerShell:masterfrom Jun 17, 2020
Merged
Add HoloLens to list of PowerShell adopters#12940iSazonov merged 4 commits intoPowerShell:masterfrom
iSazonov merged 4 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Jun 11, 2020
SteveL-MSFT
requested changes
Jun 11, 2020
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
URLs should not contain the locale as it's detected by the website. Also suggest calling out PS7 specifically since HoloLens dependency is specifically PS7+
SteveL-MSFT
requested changes
Jun 11, 2020
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
You'll also need to add the word HoloLens to our spelling dictionary right before this line: https://github.com/PowerShell/PowerShell/blob/master/.spelling#L336
Member
|
CI failure is due to #12935 and isn't blocking for this PR. |
SteveL-MSFT
approved these changes
Jun 11, 2020
Member
|
@iSazonov I think we're good to merge this one |
Collaborator
|
@SteveL-MSFT I haven't permissions to force the merging. So waiting CI-macos resolving. |
500fe8c to
9008d5e
Compare
Member
|
@iSazonov ok, I rebased this branch and that should pass CI |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add information to ADOPTERS.md describing how PowerShell is used for Microsoft HoloLens development.
Checklist