Skip to content

Replace SortedList with Generic.SortedList<TKey,TValue> #12954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jun 19, 2020
Merged

Replace SortedList with Generic.SortedList<TKey,TValue> #12954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/System.Management.Automation/engine/ManagementObjectAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ private object AuxillaryInvokeMethod(ManagementObject obj, WMIMethodCacheEntry m
/// Should not throw exceptions
/// </remarks>
internal static void UpdateParameters(ManagementBaseObject parameters,
SortedList parametersList)
SortedList<int, WMIParameterInformation> parametersList)
{
// ManagementObject class do not populate parameters when there are none.
if (parameters == null)
Expand Down Expand Up @@ -812,7 +812,7 @@ internal static MethodInformation GetMethodInformation(MethodData mData)
Diagnostics.Assert(mData != null, "MethodData should not be null");

// Get Method parameters
SortedList parameters = new SortedList();
var parameters = new SortedList<int, WMIParameterInformation>();
UpdateParameters(mData.InParameters, parameters);

// parameters is never null
Expand All @@ -832,15 +832,16 @@ internal static string GetMethodDefinition(MethodData mData)
// gather parameter information for this method.
// input and output parameters reside in 2 different groups..
// we dont know the order they appear on the arguments line..
SortedList parameters = new SortedList();
var parameters = new SortedList<int, WMIParameterInformation>();
UpdateParameters(mData.InParameters, parameters);

StringBuilder inParameterString = new StringBuilder();

if (parameters.Count > 0)
{
foreach (WMIParameterInformation parameter in parameters.Values)
for (int i = 0; i < parameters.Values.Count; i++)
{
WMIParameterInformation parameter = parameters.Values[i];
string typeName = parameter.parameterType.ToString();

PropertyData pData = mData.InParameters.Properties[parameter.Name];
Expand Down