Skip to content

Use HashSet instead of Hashtable with null values#12958

Merged
iSazonov merged 2 commits intoPowerShell:masterfrom
xtqqczze:HashSet
Jun 19, 2020
Merged

Use HashSet instead of Hashtable with null values#12958
iSazonov merged 2 commits intoPowerShell:masterfrom
xtqqczze:HashSet

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Jun 14, 2020

PR Summary

  • Replace use non-generic Hashtable
  • Dictionary not used as we don't store values.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Jun 14, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 17, 2020
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtqqczze Please rebase to pass CIs.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 18, 2020
@xtqqczze xtqqczze marked this pull request as ready for review June 18, 2020 09:18
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 18, 2020
@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Jun 19, 2020
@iSazonov iSazonov merged commit a15e509 into PowerShell:master Jun 19, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone Jun 19, 2020
@xtqqczze xtqqczze deleted the HashSet branch June 19, 2020 09:51
@ghost
Copy link
Copy Markdown

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants