Skip to content

Remove positional assignment of QUALIFIER for SPLIT-PATH#12960

Merged
daxian-dbw merged 5 commits intoPowerShell:masterfrom
yecril71pl:master
Jun 16, 2020
Merged

Remove positional assignment of QUALIFIER for SPLIT-PATH#12960
daxian-dbw merged 5 commits intoPowerShell:masterfrom
yecril71pl:master

Conversation

@yecril71pl
Copy link
Copy Markdown
Contributor

PR Summary

The syntax SPLIT-PATH C: -QUALIFIER should be required to pass QUALIFIER.

PR Context

The syntax SPLIT-PATH C: $NULL is confusing and should not be supported.

PR Checklist

The syntax ``SPLIT-PATH C: $NULL`` is confusing and should not be supported.
As of PowerShell 7.0.2, positional parameter #2 was treated by ``SPLIT-PATH`` as a value for QUALIFIER.
@iSazonov iSazonov added CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Jun 15, 2020
@daxian-dbw
Copy link
Copy Markdown
Member

This should be a bucket-3 breaking change -- Unlikely Grey Area, and I'm fine take this change.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 15, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 15, 2020
@daxian-dbw daxian-dbw dismissed adityapatwardhan’s stale review June 16, 2020 17:25

Comments addressed.

@daxian-dbw
Copy link
Copy Markdown
Member

Test-Connection failed in mac CI. It's a known issue and will be fixed by #12943

@daxian-dbw daxian-dbw merged commit 04b1214 into PowerShell:master Jun 16, 2020
@daxian-dbw daxian-dbw removed the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jun 16, 2020
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.4 milestone Jun 16, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants