Skip to content

Make sure icons are added to MSI staging folder#12983

Merged
adityapatwardhan merged 7 commits intoPowerShell:masterfrom
TravisEz13:fix-ic
Jun 22, 2020
Merged

Make sure icons are added to MSI staging folder#12983
adityapatwardhan merged 7 commits intoPowerShell:masterfrom
TravisEz13:fix-ic

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented Jun 17, 2020

PR Summary

Make sure icons are added to MSI staging folder

PR Context

fix #12799

PR Checklist

@TravisEz13 TravisEz13 marked this pull request as ready for review June 20, 2020 19:06
@TravisEz13 TravisEz13 changed the title Try to fix MSI missing icons Fix MSI missing icons Jun 20, 2020
@TravisEz13 TravisEz13 changed the title Fix MSI missing icons Make sure icons are added to MSI staging folder Jun 20, 2020
@TravisEz13 TravisEz13 added this to the 7.0.x-Servicing-Consider milestone Jun 22, 2020
@adityapatwardhan adityapatwardhan merged commit 7500513 into PowerShell:master Jun 22, 2020
@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 23, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 25, 2020
@TravisEz13
Copy link
Copy Markdown
Member Author

Evaluated for backport to 7.0 and the issue does not exist in 7.0, it was introduced in 7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon don't get placed in MSI

3 participants