Process reparse points to Microsoft Store applications#13481
Merged
rjmholt merged 2 commits intoPowerShell:masterfrom Aug 27, 2020
Merged
Process reparse points to Microsoft Store applications#13481rjmholt merged 2 commits intoPowerShell:masterfrom
rjmholt merged 2 commits intoPowerShell:masterfrom
Conversation
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Collaborator
|
I'm afraid I don't know much about reparse points or the Microsoft Store. Requesting review from @SteveL-MSFT, @anmenaga and @daxian-dbw. |
SteveL-MSFT
approved these changes
Aug 26, 2020
|
This feels like the right solution to me, especially because we're already treating IO_REPARSE_TAG_APPEXECLINK as though it were a link already. |
Collaborator
|
CI failures seem to be unrelated -- will see if there's a fix |
rjmholt
reviewed
Aug 27, 2020
src/System.Management.Automation/namespaces/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@rjmholt I rebased to pass CIs. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #9970
Add resolving a Store application path (that is a reparse point) to a real path.
SHGetFileInfo() does not understand reparse points and returns 0 ("non exe or error") so we are trying to get a real path before.
Exclude Windows code from compilation on Unix.
Exclude second extra check if an app is Windows application or console application
Add new properties (IsWindowsApplication/IsConsoleApplication) to NativeCommandProcessor to cache the check.
Before the PR we did the check twice - (1) in redirection check, (2) in background check.
I tested this manually with
C:\Users\<username>\AppData\Local\Microsoft\WindowsApps\Skype.exe./cc @DHowett
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.