PR Summary

Breaking change: this change removes the implicit public constructor for PowerShellAssemblyLoadContextInitializer.

Fix CA1822: Mark members as static.

Justification:

• There appears to be no use case for creating an instance of PowerShellAssemblyLoadContextInitializer.
• The class only contains one static method: SetPowerShellAssemblyLoadContext

PR Context

• Provide a way to host PowerShell in a CoreCLR application #2291
• https://github.com/PowerShell/PowerShell/blob/master/docs/host-powershell/README.md#special-hosting-scenario-for-native-host
• https://docs.microsoft.com/dotnet/api/system.management.automation.powershellassemblyloadcontextinitializer.setpowershellassemblyloadcontext

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • [!] None
  • OR
  • [NA] Experimental feature(s) needed
    • [NA] Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • [NA] Documentation needed
    • [NA] Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • [NS] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).