Enable nullable: System.Management.Automation.IContainsErrorRecord#14166
Merged
iSazonov merged 3 commits intoPowerShell:masterfrom Jan 9, 2021
Merged
Enable nullable: System.Management.Automation.IContainsErrorRecord#14166iSazonov merged 3 commits intoPowerShell:masterfrom
iSazonov merged 3 commits intoPowerShell:masterfrom
Conversation
iSazonov
requested changes
Nov 20, 2020
Collaborator
Author
|
The checks I see are of the type var icer = exception as IContainsErrorRecord;
if (icer == null)...But that is just checking for the interface. /// <summary>
/// Encode exception.
/// </summary>
private static PSObject EncodeException(Exception exception)
{
// We are encoding exceptions as ErrorRecord objects because exceptions written
// to the wire are lost during serialization. By sending across ErrorRecord objects
// we are able to preserve the exception as well as the stack trace.
ErrorRecord errorRecord = null;
IContainsErrorRecord containsErrorRecord = exception as IContainsErrorRecord;
if (containsErrorRecord == null)
{
// If this is a .NET exception then wrap in an ErrorRecord.
errorRecord = new ErrorRecord(exception, "RemoteHostExecutionException", ErrorCategory.NotSpecified, null);
}
else
{
// Exception inside the error record is ParentContainsErrorRecordException which
// doesn't have stack trace. Replace it with top level exception.
errorRecord = containsErrorRecord.ErrorRecord;
errorRecord = new ErrorRecord(errorRecord, exception);
}
PSObject errorRecordPSObject = RemotingEncoder.CreateEmptyPSObject();
errorRecord.ToPSObjectForRemoting(errorRecordPSObject);
return errorRecordPSObject;
}And public ErrorRecord(ErrorRecord errorRecord,
Exception replaceParentContainsErrorRecordException)
{
if (errorRecord == null)
{
throw new PSArgumentNullException(nameof(errorRecord));
}
}Clearly, the expectation is that it is non-null. I don't think the checks you see for null are what you think they are. |
Collaborator
Author
|
I think those checks are just extra precautions since we haven't had a language mechanism to help us with this. |
vexx32
approved these changes
Nov 20, 2020
iSazonov
approved these changes
Nov 21, 2020
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #12631.