Skip to content

Enable nullable: System.Management.Automation.Language.IScriptExtent#14179

Merged
iSazonov merged 3 commits intoPowerShell:masterfrom
powercode:nullable/IScriptExtent
Dec 11, 2020
Merged

Enable nullable: System.Management.Automation.Language.IScriptExtent#14179
iSazonov merged 3 commits intoPowerShell:masterfrom
powercode:nullable/IScriptExtent

Conversation

@powercode
Copy link
Copy Markdown
Collaborator

Tracking issue: #12631.

@ghost ghost assigned anmenaga Nov 19, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost
Copy link
Copy Markdown

ghost commented Nov 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov requested a review from rjmholt December 11, 2020 05:18
Copy link
Copy Markdown
Collaborator

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only we could annotate the offsets to say "may be -1"

@iSazonov iSazonov added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log and removed Review - Needed The PR is being reviewed labels Dec 11, 2020
@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Dec 11, 2020
@iSazonov iSazonov merged commit 76e471c into PowerShell:master Dec 11, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@iSazonov
Copy link
Copy Markdown
Collaborator

If only we could annotate the offsets to say "may be -1"

Add a comment in new PR?

@powercode powercode deleted the nullable/IScriptExtent branch December 14, 2020 08:17
@ghost
Copy link
Copy Markdown

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants