Fix CA1309: Use ordinal StringComparison in CertificateProvider#14352
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Jun 25, 2021
Merged
Fix CA1309: Use ordinal StringComparison in CertificateProvider#14352iSazonov merged 2 commits intoPowerShell:masterfrom
iSazonov merged 2 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Dec 9, 2020
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
iSazonov
approved these changes
Jun 24, 2021
PaulHigin
approved these changes
Jun 24, 2021
Contributor
PaulHigin
left a comment
There was a problem hiding this comment.
According to the documentation, the default string compare is ordinal. But I think it makes sense to explicitly set the Comparer to make intention clear.
vexx32
approved these changes
Jun 24, 2021
Contributor
Author
|
Contributes to #15669. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-breaking change, just makes existing behaviour explicit.
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1309