Skip to content

Fix splatting being treated as positional parameter#14623

Merged
rjmholt merged 7 commits intoPowerShell:masterfrom
MartinGC94:FixSplattingInPseudoBinder
Jun 15, 2021
Merged

Fix splatting being treated as positional parameter#14623
rjmholt merged 7 commits intoPowerShell:masterfrom
MartinGC94:FixSplattingInPseudoBinder

Conversation

@MartinGC94
Copy link
Copy Markdown
Contributor

PR Summary

Fixes #3650 where if you use splatting it counts as a positional argument so you lose the parameter in the tab completion suggestions.
For example Get-ChildItem @Splat -P won't suggest the Path parameter because @Splat is incorrectly being treated as a value for the Path parameter.

PR Context

It's annoying to forget about a parameter because IntelliSense didn't show it to you.

PR Checklist

@ghost ghost assigned anmenaga Jan 16, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 23, 2021
@ghost
Copy link
Copy Markdown

ghost commented Jan 23, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Copy link
Copy Markdown
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the code complexity check that is failing

@rjmholt rjmholt merged commit 77054ff into PowerShell:master Jun 15, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 15, 2021
@MartinGC94 MartinGC94 deleted the FixSplattingInPseudoBinder branch June 16, 2021 20:19
@rjmholt rjmholt added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jun 16, 2021
@ghost
Copy link
Copy Markdown

ghost commented Jun 17, 2021

🎉v7.2.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intellisense: Splatting is treated as a positional parameter

5 participants