Fix splatting being treated as positional parameter#14623
Merged
rjmholt merged 7 commits intoPowerShell:masterfrom Jun 15, 2021
Merged
Fix splatting being treated as positional parameter#14623rjmholt merged 7 commits intoPowerShell:masterfrom
rjmholt merged 7 commits intoPowerShell:masterfrom
Conversation
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
rjmholt
reviewed
Jun 14, 2021
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
AungMinKo070
approved these changes
Jun 14, 2021
Co-authored-by: Robert Holt <[email protected]>
rkeithhill
reviewed
Jun 15, 2021
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
rkeithhill
approved these changes
Jun 15, 2021
Collaborator
rkeithhill
left a comment
There was a problem hiding this comment.
LGTM other than the code complexity check that is failing
rjmholt
reviewed
Jun 15, 2021
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Holt <[email protected]>
rjmholt
approved these changes
Jun 15, 2021
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #3650 where if you use splatting it counts as a positional argument so you lose the parameter in the tab completion suggestions.
For example
Get-ChildItem @Splat -Pwon't suggest the Path parameter because @Splat is incorrectly being treated as a value for the Path parameter.PR Context
It's annoying to forget about a parameter because IntelliSense didn't show it to you.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.