Fix the step that updates the pwsh.deps.json link in the release pipeline#15486
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Jun 3, 2021
Merged
Fix the step that updates the pwsh.deps.json link in the release pipeline#15486adityapatwardhan merged 1 commit intoPowerShell:masterfrom
pwsh.deps.json link in the release pipeline#15486adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
Collaborator
|
(I don't understand but perhaps useful dotnet/runtime#44545 (comment)) |
Member
Author
|
@iSazonov Thanks for the pointer. This step in release build is for an internal team. We produce the deps.json file for that team to make sure they don't reference a higher library that is used by PowerShell. |
adityapatwardhan
approved these changes
Jun 3, 2021
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the
Get-Itemcommand to exclude the symbol package in the release pipeline.Otherwise, we will get an array of file paths which will result in a failure in the following
Expand-Archivecommand.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.