Fix issue with Get-Process -Module failing to stop when piped to Select-Object#15682
Merged
rjmholt merged 1 commit intoPowerShell:masterfrom Aug 12, 2021
Merged
Conversation
iSazonov
reviewed
Jun 28, 2021
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Show resolved
Hide resolved
iSazonov
approved these changes
Jun 29, 2021
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Collaborator
|
Thanks for your contribution @ArmaanMcleod! |
xtqqczze
pushed a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Aug 20, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously when running
Get-Process -Moduleand piping toSelect-Object, you would receive this error:Where the command succeeds, but the upstream output is not halted and the
Get-Process: Cannot enumerate the modules of the "pwsh" process.non-terminating error is included.To fix this, I added another clause to catch
PipelineStoppedExceptionfromWriteObject, and rethrow error, which omits the error message completely.Also added a Pester test to verify this.
PR Context
Fix #15117
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).