@daxian-dbw I looked at the implementation again, and removed the unnecessary _disposed bool, as:

• it is safe to call CancellationTokenSource.Dispose multiple times
• we don't check that _disposed == false at the beginning of each method (we let CancellationTokenSource throw the ObjectDisposedException instead)

Feel free to revert to reset to 29cdfb4 if you disagree.

@xtqqczze In that case, you don't really need to follow the exact IDisposible pattern to have the protected virtual void Dispose(bool disposing) method. This method makes sense only if the type may have derived sub types. You can put CancellationTokenSource.Dispose directly in public void Dispose() and remove GC.SuppressFinalize(this) (calling this method is in case of a sub-type has a finalizer defined. This type doesn't have a finalizer and thus won't be put on the finalizer queue)

@xtqqczze In that case, you don't really need to follow the exact IDisposible pattern to have the protected virtual void Dispose(bool disposing) method. This method makes sense only if the type may have derived sub types. You can put CancellationTokenSource.Dispose directly in public void Dispose() and remove GC.SuppressFinalize(this) (calling this method is in case of a sub-type has a finalizer defined. This type doesn't have a finalizer and thus won't be put on the finalizer queue)

@daxian-dbw I already considered those changes, but they are only possible if the class is sealed. Since ConvertToJsonCommand is currently unsealed and a public API I thought it best not to do that.

The sealed class issue reminds me of comments in #11820 (review).

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes