Use RuntimeInformation.IsOSPlatform in Microsoft.PowerShell.GlobalTool.Shim.csproj#16816
Use RuntimeInformation.IsOSPlatform in Microsoft.PowerShell.GlobalTool.Shim.csproj#16816adityapatwardhan wants to merge 2 commits intoPowerShell:masterfrom
RuntimeInformation.IsOSPlatform in Microsoft.PowerShell.GlobalTool.Shim.csproj#16816Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@adityapatwardhan Please clarify why the issue wasn't caught by CIs? Should we improve anything in CIs? |
|
This project is only built when doing a full release build. this is used for generating the global tool. It is too complicated to generate a global tool in CI. |
|
This was fixed by: #16821 |
PR Summary
Revert the change introduced in #16760 as GlobaltoolShim.cs does not depend on System.Management.Automation which defines the Platform class.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).