Skip to content

Fixing structure typo in test setup#17458

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
powercode:tabcompletion_tests_setup_fix
May 8, 2023
Merged

Fixing structure typo in test setup#17458
TravisEz13 merged 1 commit intoPowerShell:masterfrom
powercode:tabcompletion_tests_setup_fix

Conversation

@powercode
Copy link
Copy Markdown
Collaborator

@powercode powercode commented May 30, 2022

A curly brace is incorrectly placed leading to errors trying to setup tests.

PR Summary

PR Context

PR Checklist

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.ps1 : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@powercode
Copy link
Copy Markdown
Collaborator Author

Maybe worth trying to understand why this bug was undetected for so long.

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 6, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jun 6, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13
Copy link
Copy Markdown
Member

/azp run PowerShell-CI-macos

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 6, 2022
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13
Copy link
Copy Markdown
Member

/remind me tomorrow

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 6, 2022

@TravisEz13 set a reminder for 6/7/2022

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2022

👋 @TravisEz13,

@github-actions github-actions bot removed the reminder label Jun 7, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 14, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jun 14, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw daxian-dbw requested a review from TravisEz13 June 28, 2022 19:48
@TravisEz13
Copy link
Copy Markdown
Member

/azp run PowerShell-CI-windows

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 18, 2022
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13
Copy link
Copy Markdown
Member

/remind me tomorrow

@github-actions
Copy link
Copy Markdown
Contributor

@TravisEz13 set a reminder for 8/19/2022

@github-actions
Copy link
Copy Markdown
Contributor

👋 @TravisEz13,

@github-actions github-actions bot removed the reminder label Aug 19, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 26, 2022
@ghost
Copy link
Copy Markdown

ghost commented Aug 26, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13 TravisEz13 merged commit 33dc1a8 into PowerShell:master May 8, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label May 8, 2023
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jun 28, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@powercode powercode deleted the tabcompletion_tests_setup_fix branch August 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants