Fix positional argument completion by MartinGC94 · Pull Request #17796 · PowerShell/PowerShell

MartinGC94 · 2022-07-28T19:35:19Z

PR Summary

Fixes #17653
Instead of looking for a parameter with the exact location specified, it instead looks for the parameter with a position closest to the specified location. This fixes completion for positional parameters where an earlier positional parameter has been specified by name so the completion should look for the next positional parameter.

PR Context

PR Checklist

iSazonov · 2022-07-29T05:40:13Z

test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1

+        $Param2
+    )
+}
+Verb-Noun -Param1 Hello ^


What about more complex test like (expect Value3 in parameter position 3)
Verb-Noun -ParamPos0 Value0 ParamPos1Value1 -ParamPos2 Value2 ^

Is it necessary? The logic would be the same as in the previous test: It takes the next available positional parameter. It doesn't really matter if it's the first, third or even the 30th parameter position it's looking for.

The code is too big to observe its logic in its entirety, and the test I'm asking about is a case I thought it might not work.

That's fair. Here's how it works: The target position is found elsewhere and is based on how many positionally bound parameters have been specified, in the above example it would look for the second positional parameter (position 1) because one other positional parameter has been found.
The loop I've modified loops over the unbound parameters and parametersets that are valid based on the currently bound parameters, here it looks for any positional parameters with a position greater than or equal to the target location. It then saves whichever parameter has the lowest position and binds the argument to that.
Because it's looping over unbound parameters all the previous parameters "ParamPos0", "ParamPos1" and "ParamPos2" are automatically filtered out so the next available parameter would be "ParamPos3".

ghost · 2022-08-07T14:01:15Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs

…letionCompleters.cs Co-authored-by: Ilya <[email protected]>

daxian-dbw

LGTM

daxian-dbw · 2022-08-22T19:59:11Z

@MartinGC94 Can you please rebase? I think the failures come from a different PR that was merged.

pull-request-quantifier-deprecated · 2022-08-22T21:21:48Z

This PR has 45 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +33 -12
Percentile : 18%

Total files changed: 2

Change summary by file extension:
.cs : +16 -12
.ps1 : +17 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

daxian-dbw · 2022-08-22T22:18:17Z

@MartinGC94 Thanks for the improvements!

ghost · 2022-12-20T22:58:43Z

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Fix positional argument completion

6a162f6

ghost assigned adityapatwardhan Jul 28, 2022

MartinGC94 and others added 2 commits July 28, 2022 21:41

Merge branch 'master' into FixPositionalArgumentCompletion

b8f20b8

Fix merge conflict

5f4ace3

iSazonov reviewed Jul 29, 2022

View reviewed changes

ghost added the Review - Needed The PR is being reviewed label Aug 7, 2022

iSazonov approved these changes Aug 11, 2022

View reviewed changes

src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Show resolved Hide resolved

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 11, 2022

iSazonov requested a review from daxian-dbw August 11, 2022 17:12

Update src/System.Management.Automation/engine/CommandCompletion/Comp…

25e2f9b

…letionCompleters.cs Co-authored-by: Ilya <[email protected]>

pull-request-quantifier-deprecated bot added the Extra Small label Aug 11, 2022

MartinGC94 closed this Aug 15, 2022

MartinGC94 reopened this Aug 15, 2022

Minor update to a comment

0e9d688

daxian-dbw approved these changes Aug 22, 2022

View reviewed changes

daxian-dbw assigned daxian-dbw and unassigned adityapatwardhan Aug 22, 2022

ghost removed the Review - Needed The PR is being reviewed label Aug 22, 2022

MartinGC94 added 2 commits August 22, 2022 22:36

Merge branch 'PowerShell:master' into FixPositionalArgumentCompletion

54d073a

Merge branch 'PowerShell:master' into FixPositionalArgumentCompletion

ee31af5

daxian-dbw merged commit 99c757f into PowerShell:master Aug 22, 2022

MartinGC94 deleted the FixPositionalArgumentCompletion branch August 23, 2022 16:07

TravisEz13 mentioned this pull request Sep 30, 2022

Move ApiScan to compliance build #18191

Merged

22 tasks

MartinGC94 mentioned this pull request Dec 8, 2022

Prioritize the default parameter set when completing positional args #18755

Merged

22 tasks

ghost mentioned this pull request Dec 20, 2022

Pseudo binding for tab completion doesn't work property for positional arguments #17653

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix positional argument completion#17796

Fix positional argument completion#17796
daxian-dbw merged 7 commits intoPowerShell:masterfrom
MartinGC94:FixPositionalArgumentCompletion

MartinGC94 commented Jul 28, 2022

Uh oh!

iSazonov Jul 29, 2022

Uh oh!

MartinGC94 Jul 29, 2022

Uh oh!

iSazonov Jul 31, 2022

Uh oh!

MartinGC94 Jul 31, 2022

Uh oh!

ghost commented Aug 7, 2022

Uh oh!

Uh oh!

daxian-dbw left a comment

Uh oh!

daxian-dbw commented Aug 22, 2022

Uh oh!

pull-request-quantifier-deprecated bot commented Aug 22, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

daxian-dbw commented Aug 22, 2022

Uh oh!

ghost commented Dec 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MartinGC94 commented Jul 28, 2022

PR Summary

PR Context

PR Checklist

Uh oh!

iSazonov Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

MartinGC94 Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

iSazonov Jul 31, 2022

Choose a reason for hiding this comment

Uh oh!

MartinGC94 Jul 31, 2022

Choose a reason for hiding this comment

Uh oh!

ghost commented Aug 7, 2022

Uh oh!

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

daxian-dbw commented Aug 22, 2022

Uh oh!

pull-request-quantifier-deprecated bot commented Aug 22, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

daxian-dbw commented Aug 22, 2022

Uh oh!

ghost commented Dec 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants