Skip to content

Make the static constructor of PSVersionInfo run faster for stable PowerShell releases#18210

Merged
daxian-dbw merged 7 commits intoPowerShell:masterfrom
daxian-dbw:psv
Oct 6, 2022
Merged

Make the static constructor of PSVersionInfo run faster for stable PowerShell releases#18210
daxian-dbw merged 7 commits intoPowerShell:masterfrom
daxian-dbw:psv

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw commented Oct 3, 2022 •
edited
Loading

PR Summary

Make the static constructor of PSVersionInfo run faster for stable PowerShell releases.

Major changes are:

  1. Fast parse the pre-defined PowerShell version string, instead of going through SemanticVersion.Parse(string).
  2. Change all legacy versions to use Version instead of SemanticVersion, to avoid the overhead of casting when using them for $PSVersionTable.PSCompatibleVersions.
  3. Simplify the constructor of ConsoleHostRawUserInterface to not use Regex.

PR Checklist

@daxian-dbw daxian-dbw requested a review from anmenaga as a code owner October 3, 2022 21:37
@ghost ghost assigned iSazonov Oct 3, 2022
@daxian-dbw daxian-dbw added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log and removed CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Oct 3, 2022
daxian-dbw
daxian-dbw commented Oct 3, 2022
View reviewed changes
daxian-dbw
daxian-dbw commented Oct 3, 2022
View reviewed changes
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostRawUserInterface.cs Outdated
Copy link
Copy Markdown
Member Author

@daxian-dbw daxian-dbw Oct 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to get rid of using Regex at startup, which is not necessary.

@daxian-dbw daxian-dbw requested review from SeeminglyScience, adityapatwardhan and iSazonov and removed request for anmenaga October 3, 2022 21:42
@daxian-dbw daxian-dbw mentioned this pull request Oct 4, 2022
Merged
22 tasks
iSazonov
iSazonov reviewed Oct 4, 2022
View reviewed changes
SeeminglyScience
SeeminglyScience reviewed Oct 4, 2022
View reviewed changes
SeeminglyScience
SeeminglyScience reviewed Oct 4, 2022
View reviewed changes
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Oct 5, 2022

@daxian-dbw I think we should use SG to put all that are used at startup (one const I guess?) in separate helper so that exclude PSVersion static class initialization at startup. As result we can reduce number our optimizations in PSVersion class and safe our time.

daxian-dbw added a commit to iSazonov/PowerShell that referenced this pull request Oct 6, 2022
@daxian-dbw
Merge part of PowerShell#18210 to the source generator and also refac…
f09bd4d 
…tor it
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Oct 6, 2022

This PR has 62 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Small
Size       : +27 -35
Percentile : 24.8%

Total files changed: 3

Change summary by file extension:
.cs : +26 -31
.resx : +1 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw
Copy link
Copy Markdown
Member Author

daxian-dbw commented Oct 6, 2022

@iSazonov @SeeminglyScience The FastParsePSVersion function and its related changes were reverted, because I have already integrated those changes to the source generated PR. See #15603 (review) and that PR has been updated.

So, what's left in this PR is much simpler. Please review again.

iSazonov
iSazonov reviewed Oct 6, 2022
View reviewed changes
SeeminglyScience
SeeminglyScience approved these changes Oct 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Love it ❤️

@daxian-dbw daxian-dbw merged commit 7073525 into PowerShell:master Oct 6, 2022
@daxian-dbw daxian-dbw deleted the psv branch October 6, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@iSazonov iSazonov

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daxian-dbw @iSazonov @SeeminglyScience