Cleanup webrequestpscmdlet.common.cs by CarloToso · Pull Request #18596 · PowerShell/PowerShell

CarloToso · 2022-11-17T11:11:02Z

PR Summary

Small cleanup for better readibility

CarloToso · 2022-11-17T21:46:03Z

Should I remove redundant brackets ? (example: if (PassThru && (OutFile == null)))

iSazonov · 2022-11-18T06:41:40Z

@CarloToso You could look CodeFactor issues reported for the file and fix some ones.

ghost · 2022-11-25T14:00:56Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

…yCount

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

iSazonov · 2022-12-14T04:16:46Z

@CarloToso Please squash last commits after "revert =0" - difficult to review last changes.
To be clear - I ask you only use is null and is not null.

== -> is remove useless return; fixed errors revert

CarloToso · 2022-12-15T00:43:18Z

Squashed

iSazonov · 2022-12-15T05:56:38Z

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

            }

-            if (Authentication != WebAuthenticationType.None && Token != null && Credential != null)
+            if (Authentication is not WebAuthenticationType.None && Token is not null && Credential is not null)


Please revert patterns like Authentication is not WebAuthenticationType.None. Let's limit the PR only to is null and is not null.

Or better move this in follow PR after we merge that.

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

iSazonov · 2022-12-15T16:32:49Z

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

+            if (xmlNode is null)
                return 0;


Suggested change

if (xmlNode is null)

return 0;

if (xmlNode is null)

{

return 0;

}

…Cmdlet/Common/WebRequestPSCmdlet.Common.cs

pull-request-quantifier-deprecated · 2022-12-15T16:34:02Z

This PR has 228 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +101 -127
Percentile : 62.8%

Total files changed: 1

Change summary by file extension:
.cs : +101 -127

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

ghost · 2022-12-20T22:58:04Z

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

CarloToso added 2 commits November 17, 2022 10:25

cleanup string.Format

3754ed4

cleanup &&

39730a3

CarloToso requested a review from PaulHigin as a code owner November 17, 2022 11:11

pull-request-quantifier-deprecated bot added the Extra Small label Nov 17, 2022

ghost assigned anmenaga Nov 17, 2022

iSazonov approved these changes Nov 17, 2022

View reviewed changes

iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 17, 2022

CarloToso added 2 commits November 18, 2022 10:00

remove empty comments

14c6ead

GetValidationError single line

6f9d9bf

pull-request-quantifier-deprecated bot added Small and removed Extra Small labels Nov 18, 2022

Remove redundant brackets

a472912

pull-request-quantifier-deprecated bot added Medium and removed Small labels Nov 18, 2022

CarloToso added 3 commits November 18, 2022 10:25

remove more unnecessary parenthesis

69c71d4

{

7702518

body of if wrapped in curly brackets

02b6fde

iSazonov approved these changes Nov 18, 2022

View reviewed changes

ghost added the Review - Needed The PR is being reviewed label Nov 25, 2022

CarloToso added 4 commits December 1, 2022 09:49

Merge branch 'master' into cleanup-WebRequestPSCmdlet.Common.cs

14539f1

cleanup MaximumRedirection; clearer definition of default MaximumRetr…

a2099f4

…yCount

cleanup Method and CustomMethod get-set

1eadb01

replace get { return with =>

846d0ef

iSazonov requested changes Dec 13, 2022

View reviewed changes

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Dec 13, 2022

revert =0

778b5cd

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 13, 2022

pull-request-quantifier-deprecated bot added Large and removed Medium labels Dec 13, 2022

CarloToso mentioned this pull request Dec 14, 2022

Replace ArgumentNullException(nameof()) -> ArgumentNullException.ThrowIfNull() #18784

Merged

!= -> is not - remove leftover ;

e803d64

== -> is remove useless return; fixed errors revert

CarloToso force-pushed the cleanup-WebRequestPSCmdlet.Common.cs branch from b893b60 to e803d64 Compare December 15, 2022 00:27

Merge branch 'master' into cleanup-WebRequestPSCmdlet.Common.cs

829cdef

fix double blank line

794edcb

iSazonov reviewed Dec 15, 2022

View reviewed changes

CarloToso added 2 commits December 15, 2022 11:32

reverted

6011edc

fixed

918e515

iSazonov reviewed Dec 15, 2022

View reviewed changes

iSazonov added 2 commits December 15, 2022 21:33

Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Web…

657bc3e

…Cmdlet/Common/WebRequestPSCmdlet.Common.cs

Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Web…

9aa6615

…Cmdlet/Common/WebRequestPSCmdlet.Common.cs

iSazonov approved these changes Dec 15, 2022

View reviewed changes

iSazonov assigned iSazonov and unassigned anmenaga Dec 15, 2022

iSazonov merged commit bcb0a94 into PowerShell:master Dec 15, 2022

CarloToso deleted the cleanup-WebRequestPSCmdlet.Common.cs branch December 15, 2022 18:00

Conversation

CarloToso commented Nov 17, 2022

PR Summary

Uh oh!

CarloToso commented Nov 17, 2022

Uh oh!

iSazonov commented Nov 18, 2022

Uh oh!

ghost commented Nov 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iSazonov commented Dec 14, 2022

Uh oh!

CarloToso commented Dec 15, 2022

Uh oh!

iSazonov Dec 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov Dec 15, 2022

Choose a reason for hiding this comment

Uh oh!

CarloToso Dec 15, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iSazonov Dec 15, 2022

Choose a reason for hiding this comment

Uh oh!

pull-request-quantifier-deprecated bot commented Dec 15, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

ghost commented Dec 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

iSazonov Dec 15, 2022 •

edited

Loading