Allow system lock down test debug hook to work with new wldp API (fixes system lock down tests) by PaulHigin · Pull Request #18962 · PowerShell/PowerShell

PaulHigin · 2023-01-17T22:24:32Z

PR Summary

This PR fixes system lock down tests when running on a Windows platform version with CanExecuteFile API.

PR Context

The system lock down code first looks for CanExecuteFile API before reverting to legacy API when testing a single script file. However, the test debug hook is implemented in the legacy API. So when the debug hook is in effect, it should always use legacy API for single script file check.

PR Checklist

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

pull-request-quantifier-deprecated · 2023-01-17T22:24:37Z

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.cs : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

ghost · 2023-01-24T19:34:41Z

🎉v7.3.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…es system lock down tests) (PowerShell#18962)

ghost · 2023-03-14T22:24:47Z

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

PaulHigin and others added 30 commits January 17, 2023 13:40

Rebase conflict again

36aad8a

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

f272758

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

12d10b8

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

70908e4

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

1e5b6fc

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Update PSGalleryModules correctly

7dbd535

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

10e704c

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

8122cac

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

5f94cba

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

9bb5bc4

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

d957681

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

rebase conflict

b29e3d4

Rebase conflict again

513350c

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

d81b300

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

6758480

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

abc2ddf

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

779f73e

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Update PSGalleryModules correctly

e1d0b7f

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

422f853

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

4e3bf79

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

e424802

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

de59523

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

66d8aa8

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

rebase conflict

8ecf789

Rebase conflict again

7cfe47a

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

efb2240

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

374f5f2

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

34e0a99

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

bebdc34

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Update PSGalleryModules correctly

f72bc5a

PaulHigin and others added 11 commits January 17, 2023 13:40

rebase conflict

4780ef7

Rebase conflict again

5e575e5

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

4dcca61

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

01aba36

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

7a2b608

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

fd3b1c3

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

4b90b90

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

9ef94a7

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump PSReadLine from 2.1.0 to 2.2.2 in /src/Modules

4c72073

Bumps PSReadLine from 2.1.0 to 2.2.2. --- updated-dependencies: - dependency-name: PSReadLine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Merge branch 'master' of https://github.com/PaulHigin/PowerShell

c5e822c

Allow debug hook with new API

6569b7a

PaulHigin requested a review from TravisEz13 as a code owner January 17, 2023 22:24

pull-request-quantifier-deprecated bot added the Extra Small label Jan 17, 2023

ghost assigned TravisEz13 Jan 17, 2023

PaulHigin requested a review from adityapatwardhan January 17, 2023 22:24

TravisEz13 approved these changes Jan 18, 2023

View reviewed changes

TravisEz13 removed the Backport-7.2.x-Consider label Jan 18, 2023

TravisEz13 merged commit 5f8f15a into PowerShell:master Jan 18, 2023

TravisEz13 added Backport-7.3.x-Done and removed Backport-7.3.x-Consider labels Jan 18, 2023

olljanat pushed a commit to olljanat/PowerShell that referenced this pull request Feb 24, 2023

Allow system lock down test debug hook to work with new wldp API (fix…

db6e079

…es system lock down tests) (PowerShell#18962)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow system lock down test debug hook to work with new wldp API (fixes system lock down tests)#18962

Allow system lock down test debug hook to work with new wldp API (fixes system lock down tests)#18962
TravisEz13 merged 3083 commits intoPowerShell:masterfrom
PaulHigin:fix-policy-debug

PaulHigin commented Jan 17, 2023

Uh oh!

pull-request-quantifier-deprecated bot commented Jan 17, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

ghost commented Jan 24, 2023

Uh oh!

ghost commented Mar 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

PaulHigin commented Jan 17, 2023

PR Summary

PR Context

PR Checklist

Uh oh!

pull-request-quantifier-deprecated bot commented Jan 17, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

ghost commented Jan 24, 2023

Uh oh!

ghost commented Mar 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants