Conversation
iSazonov
left a comment
There was a problem hiding this comment.
@CarloToso Something wrong in the PR (module manifest test fails). Need investigate.
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
Outdated
Show resolved
Hide resolved
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
| private string ManifestFragmentForNonSpecifiedManifestMember(string key, string resourceString, string value, StreamWriter streamWriter) | ||
| { | ||
| return string.Format(CultureInfo.InvariantCulture, "{0}# {1}{2}{0}# {3:19} = {4}{2}{2}", | ||
| _indent, resourceString, streamWriter.NewLine, key, value); |
There was a problem hiding this comment.
What could we use to replace streamWriter.NewLine?
There was a problem hiding this comment.
Environment.NewLine but only for test. If you think this is a root of issue revert the change to string.Format.
There was a problem hiding this comment.
NewModuleManifestCommand.cs is the problem (after we merge #18996 and #18997 we can close this PR)
PR Summary
Replace
string.Format()with newstring.Create((IFormatProvider? provider, [InterpolatedStringHandlerArgument(nameof(provider))] ref DefaultInterpolatedStringHandler handler).PR Context
#18974
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).