Skip to content

Use interpolated strings 12#19003

Merged
iSazonov merged 7 commits intoPowerShell:masterfrom
CarloToso:Use-interpolated-strings-12
Jan 23, 2023
Merged

Use interpolated strings 12#19003
iSazonov merged 7 commits intoPowerShell:masterfrom
CarloToso:Use-interpolated-strings-12

Conversation

@CarloToso
Copy link
Copy Markdown
Contributor

@CarloToso CarloToso commented Jan 21, 2023 •
edited by iSazonov
Loading

PR Summary

Replace string.Format() with new string.Create((IFormatProvider? provider, [InterpolatedStringHandlerArgument(nameof(provider))] ref DefaultInterpolatedStringHandler handler).

PR Context

#18974, I think this is the last one

PR Checklist

@CarloToso CarloToso requested a review from PaulHigin as a code owner January 21, 2023 18:57
@ghost ghost assigned daxian-dbw Jan 21, 2023
@CarloToso CarloToso closed this Jan 21, 2023
@CarloToso CarloToso reopened this Jan 21, 2023
@CarloToso
Copy link
Copy Markdown
Contributor Author

CarloToso commented Jan 21, 2023

@iSazonov What is the preferred solution ? streamWriter.NewLine -> streamWriter.NewLine.ToString() or streamWriter.NewLine -> Environment.NewLine

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Jan 22, 2023

@iSazonov What is the preferred solution ? streamWriter.NewLine -> streamWriter.NewLine.ToString() or streamWriter.NewLine -> Environment.NewLine

We can not use Environment.NewLine since streamWriter can use any value.
streamWriter.NewLine doesn't work but streamWriter.NewLine.ToString()? If so we can use second one.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Jan 22, 2023

Maybe it's not worth the effort.

@iSazonov iSazonov self-requested a review January 23, 2023 12:35
iSazonov
iSazonov requested changes Jan 23, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarloToso Again an test fails.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 23, 2023
@CarloToso
Copy link
Copy Markdown
Contributor Author

CarloToso commented Jan 23, 2023 •
edited
Loading

@iSazonov I don't know why the tests are failing, it doesn't make any sense. Maybe it was a random error

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 23, 2023
@CarloToso CarloToso closed this Jan 23, 2023
@CarloToso CarloToso reopened this Jan 23, 2023
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Jan 23, 2023

This PR has 17 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +4 -13
Percentile : 6.8%

Total files changed: 3

Change summary by file extension:
.cs : +4 -13

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Jan 23, 2023
@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Jan 23, 2023
@iSazonov iSazonov merged commit 33ba573 into PowerShell:master Jan 23, 2023
@CarloToso CarloToso deleted the Use-interpolated-strings-12 branch January 23, 2023 17:37
daxian-dbw
daxian-dbw reviewed Jan 23, 2023
View reviewed changes
src/System.Management.Automation/engine/runtime/Binding/Binders.cs
_allowSlicing ? string.Empty : " slicing disallowed",
_constraints == null ? string.Empty : " constraints: " + _constraints,
_version);
return string.Create(CultureInfo.InvariantCulture, $"PSGetIndexBinder indexCount={this.CallInfo.ArgumentCount}{(_allowSlicing ? string.Empty : " slicing disallowed")}{(_constraints == null ? string.Empty : " constraints: " + _constraints)} ver:{_version}");
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov I think this is way less readable than the original code, don't you think so?

Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more about reducing allocations. My suggestions for improvement I outlined in your PR.

@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw left review comments

@iSazonov iSazonov iSazonov approved these changes

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@iSazonov iSazonov

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarloToso @iSazonov @daxian-dbw