Skip to content

Add a mariner install script#19294

Merged
TravisEz13 merged 8 commits intomasterfrom
mariner-inst
Mar 8, 2023
Merged

Add a mariner install script#19294
TravisEz13 merged 8 commits intomasterfrom
mariner-inst

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented Mar 8, 2023 •
edited
Loading

PR Summary

Add mariner support in the powershell installer script for Linux

  • mariner uses the tar.gz, so the installation is self contained.
  • updated ubuntu installer, so that CI pasts

PR Context

PR Checklist

@ghost ghost assigned anmenaga Mar 8, 2023
TravisEz13
TravisEz13 commented Mar 8, 2023
View reviewed changes
JamesWTruher
JamesWTruher approved these changes Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine - I've got questions, but everything looks fine.

.vsts-ci/install-ps.yml
pool: ubuntu-latest
verification: |
if ([Version]"$($PSVersionTable.PSVersion.Major).$($PSVersionTable.PSVersion.Minor).$($PSVersionTable.PSVersion.Patch)" -lt [version]"6.2.0")
if ([Version]"$($PSVersionTable.PSVersion.Major).$($PSVersionTable.PSVersion.Minor).$($PSVersionTable.PSVersion.Patch)" -lt [version]"7.3.0")
Copy link
Copy Markdown
Collaborator

@JamesWTruher JamesWTruher Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be expressed as:
if([Version]$PSVersionTable.PSVersion -lt "7.3.0")
we did some stuff to enable converting a semanticversion into a version, but it's fine as is

.vsts-ci/install-ps.yml

- template: templates/install-ps-phase.yml
parameters:
scriptName: sudo ./tools/install-powershell.sh
Copy link
Copy Markdown
Collaborator

@JamesWTruher JamesWTruher Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by this - do we actually get the version from the current installed pwsh or the new one? and will this script be executable in the container?

Copy link
Copy Markdown
Member Author

@TravisEz13 TravisEz13 Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verification runs after we run the install script. It's possible it's the old pwsh, but the verification is only intended to catch issues that we have had in the past, which is mainly that the installation left the system in a bad state.

tools/installpsh-mariner.sh
OS=osx
DistroBasedOn=osx
else
OS=$(uname)
Copy link
Copy Markdown
Collaborator

@JamesWTruher JamesWTruher Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why we don't use the lowercase OS created in line 52, but ok

Copy link
Copy Markdown
Member Author

@TravisEz13 TravisEz13 Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is template code shared across many scripts. I only added code for mariner. I think we could redesign this, but I don't think it's needed.

tools/installpsh-mariner.sh
if [[ $osname = *SUSE* ]]; then
DistroBasedOn='suse'
fi
OS=$(lowercase "$OS")
Copy link
Copy Markdown
Collaborator

@JamesWTruher JamesWTruher Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol - lowercase again

@TravisEz13 TravisEz13 marked this pull request as ready for review March 8, 2023 19:33
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Mar 8, 2023

This PR has 204 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +197 -7
Percentile : 60.4%

Total files changed: 4

Change summary by file extension:
.yml : +14 -5
.sh : +183 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned anmenaga Mar 8, 2023
@TravisEz13 TravisEz13 added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Mar 8, 2023
@TravisEz13 TravisEz13 merged commit 740e689 into master Mar 8, 2023
@TravisEz13 TravisEz13 deleted the mariner-inst branch March 8, 2023 21:35
@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TravisEz13 @JamesWTruher @anmenaga