Skip to content

Apply IDE0019: InlineAsTypeCheck in Management.Automation.FormatAndOutput#19694

Merged
daxian-dbw merged 4 commits intoPowerShell:masterfrom
Molkree:ide0019-management-automation-formatandoutput
Jul 11, 2023
Merged

Apply IDE0019: InlineAsTypeCheck in Management.Automation.FormatAndOutput#19694
daxian-dbw merged 4 commits intoPowerShell:masterfrom
Molkree:ide0019-management-automation-formatandoutput

Conversation

@Molkree
Copy link
Copy Markdown
Contributor

@Molkree Molkree commented May 21, 2023 •
edited
Loading

PR Summary

Fix IDE0019 in Management.Automation.FormatAndOutput folder.

PR Context

#18399
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0019
Microsoft.CodeAnalysis.CSharp version 4.6.0-1.final.
There might have been some manual fixes in this PR but they all fall into 3 categories:

  1. Newly created double newlines that trigger other diagnostics.
  2. Code that previously looked like this 
    if (condition)
{
    Type type = var as Type;
    if (type != null)
    ...
    was fixed to this: 
    if (condition)
{
    if (var is Type type)
    ...
    and I have additionally changed it to this: 
    if (condition && var is Type type)
{
    ...
  3. Once or twice autofix "ate" comments but it might have been in another PR. You can see all similar PRs in the linked issue.

PR Checklist

@ghost ghost assigned daxian-dbw May 21, 2023
@StevenBucher98 StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label May 22, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 4, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jun 4, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

SteveL-MSFT
SteveL-MSFT approved these changes Jun 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daxian-dbw
daxian-dbw approved these changes Jul 10, 2023
View reviewed changes
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Jul 10, 2023

This PR has 235 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +81 -154
Percentile : 63.5%

Total files changed: 22

Change summary by file extension:
.cs : +81 -154

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw merged commit a26b09d into PowerShell:master Jul 11, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 11, 2023
@Molkree Molkree deleted the ide0019-management-automation-formatandoutput branch July 12, 2023 21:27
@SeeminglyScience SeeminglyScience added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@daxian-dbw daxian-dbw

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Large PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Molkree @daxian-dbw @SteveL-MSFT @StevenBucher98 @SeeminglyScience