Skip to content

Fix unixmode to handle setuid/sticky when not executable#20366

Merged
daxian-dbw merged 9 commits intoPowerShell:masterfrom
JamesWTruher:UnixModeStringFix01
Oct 11, 2023
Merged

Fix unixmode to handle setuid/sticky when not executable#20366
daxian-dbw merged 9 commits intoPowerShell:masterfrom
JamesWTruher:UnixModeStringFix01

Conversation

@JamesWTruher
Copy link
Copy Markdown
Collaborator

@JamesWTruher JamesWTruher commented Sep 25, 2023

PR Summary

This is a fix for #20278

PR Context

I'm not addressing the CodeFactor reported complexity as I don't believe this method is overly complicated.

PR Checklist

@StevenBucher98 StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Sep 25, 2023
@JamesWTruher JamesWTruher added the WG-Engine core PowerShell engine, interpreter, and runtime label Sep 25, 2023
@JamesWTruher JamesWTruher changed the title WIP: fix unixmode to handle setuid/sticky when not executable Fx unixmode to handle setuid/sticky when not executable Sep 25, 2023
@JamesWTruher JamesWTruher changed the title Fx unixmode to handle setuid/sticky when not executable Fix unixmode to handle setuid/sticky when not executable Sep 25, 2023
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 68 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +41 -27
Percentile : 27.2%

Total files changed: 2

Change summary by file extension:
.cs : +30 -25
.ps1 : +11 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Oct 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Oct 11, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 11, 2023
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added BackPort-7.4.x-Consider and removed WG-Engine core PowerShell engine, interpreter, and runtime labels Oct 11, 2023
@daxian-dbw daxian-dbw enabled auto-merge (squash) October 11, 2023 23:29
@daxian-dbw daxian-dbw merged commit 81a7f6f into PowerShell:master Oct 11, 2023
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service bot commented Oct 11, 2023

📣 Hey @JamesWTruher, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://forms.office.com/r/P926k48jRJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants