Fix Group-Object output using interpolated strings#20745
Merged
iSazonov merged 4 commits intoPowerShell:masterfrom Nov 30, 2023
Merged
Fix Group-Object output using interpolated strings#20745iSazonov merged 4 commits intoPowerShell:masterfrom
Group-Object output using interpolated strings#20745iSazonov merged 4 commits intoPowerShell:masterfrom
Conversation
Fixes regression from PowerShell#20608 which mixed up use of `StringBuilder.AppendFormat` and interpolated strings, thereby passing the actual value to be formatted as the format string. Fixes PowerShell#20711.
Contributor
Author
Collaborator
|
@mawosoft Thanks! Please add test(s) to avoid future regressions. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
@iSazonov Test added. |
iSazonov
reviewed
Nov 22, 2023
test/powershell/Modules/Microsoft.PowerShell.Utility/Group-Object.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Nov 22, 2023
test/powershell/Modules/Microsoft.PowerShell.Utility/Group-Object.Tests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <[email protected]>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
iSazonov
approved these changes
Nov 23, 2023
SteveL-MSFT
approved these changes
Nov 29, 2023
5 tasks
Collaborator
|
@SteveL-MSFT Maybe backport? |
Group-Object output using interpolated strings
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes regression from #20608 which mixed up use of
StringBuilder.AppendFormatand interpolated strings, thereby passing the actual value to be formatted as the format string.PR Context
Fixes #20711.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).