Remove SuppressFinalize from ClientRemoteSessionDSHandlerImpl#21218
Remove SuppressFinalize from ClientRemoteSessionDSHandlerImpl#21218iSazonov merged 3 commits intoPowerShell:masterfrom
SuppressFinalize from ClientRemoteSessionDSHandlerImpl#21218Conversation
The motivation of this PR is this comment by @PaulHigin PowerShell#11820 (comment). _Contributes to PowerShell#15110._
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
ClientRemoteSessionDSHandlerImplClientRemoteSessionDSHandlerImpl
src/System.Management.Automation/engine/remoting/client/remotingprotocolimplementation.cs
Outdated
Show resolved
Hide resolved
ClientRemoteSessionDSHandlerImplSuppressFinalize from ClientRemoteSessionDSHandlerImpl
|
📣 Hey @xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Follow-up to #24705.
GC.SuppressFinalizeshould not be invoked for types without a finalizer.ClientRemoteSessionDSHandlerImplis sealed therefore cannot have a finalizer.