Update format-hex tests to include -TestCase parameter by MiaRomero · Pull Request #3800 · PowerShell/PowerShell

MiaRomero · 2017-05-17T18:20:04Z

Addressing issue #3382 'Use -TestCases parameter in FormatHex.Tests.ps1'.

Replaced the 'foreach' with the -TestCases parameter in the test helper functions.

JamesWTruher · 2017-05-18T00:01:44Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

I think that these functions should just be inlined into the appropriate context block. Having these functions only makes things a little harder to find. it allows the test case data be closer to the actual test.

lzybkr · 2017-05-18T19:42:15Z

@MiaRomero - the assignee of a PR is the person responsible for merging to master - and only maintainers can do that merge. We assign issues to regular contributors, but not the PR.

mirichmo · 2017-05-23T15:17:30Z

@JamesWTruher or @Francisco-Gamino - Do you guys have any other concerns or comments?

mirichmo · 2017-05-25T00:56:07Z

@MiaRomero - We need to add you to the Microsoft organization. I just noticed that you are not a member yet.

iSazonov · 2017-05-25T05:57:48Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

We should check $output.Count >=1 or =1 not $null

iSazonov · 2017-05-25T05:59:25Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

We can remove - next line make the check.

Thanks, removed in all mentioned instances.

iSazonov · 2017-05-25T05:59:43Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

We can remove - next line make the check.

iSazonov · 2017-05-25T06:00:12Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

We can remove - next line make the check.

iSazonov · 2017-05-25T06:00:29Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

We can remove - next line make the check.

iSazonov · 2017-05-25T06:01:00Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

We can remove - next line make the check.

iSazonov · 2017-05-25T06:01:31Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

We can remove - next line make the check.

MiaRomero · 2017-06-06T19:12:30Z

@JamesWTruher fixed the >1 issue. The way it was before was not actually testing the contents of the second file so when I corrected it, those tests failed because the output was on two lines. I changed the input text to avoid the hassle of having two lines of output in the second expected result (then had to create a file with longer text to test the buffer underrun).

JamesWTruher · 2017-06-30T18:00:48Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1


    Context "Continues to Process Valid Paths" {

+        $skipTest = ([System.Management.Automation.Platform]::IsLinux -or [System.Management.Automation.Platform]::IsOSX)


I'd be happier if this was combined with the construct in 378
IsLinux -or IsOSX -or (-not $certProviderAvailable)
then 378 could just be:
It "<Name>" -Skip:$skip
same with the code below

adityapatwardhan · 2017-08-16T17:56:16Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

    }

-    Context "Path Paramater" {
+    Context "Path and LiteralPath Paramaters" {


Typo in Paramaters -> Parameters

adityapatwardhan · 2017-08-16T18:57:18Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+                $output = Format-Hex -LiteralPath $InvalidPath, $inputFile1 -ErrorVariable errorThrown -ErrorAction SilentlyContinue
+            }
+
+            $errorThrown.FullyQualifiedErrorId | Should Match $ExpectedFullyQualifiedErrorId


Please use ShouldBeErrorId, like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Diagnostics/New-WinEvent.Tests.ps1

Line 27 in 0b7451b

{ New-WinEvent -ProviderName NonExistingProvider -Id 0 } | ShouldBeErrorId 'System.ArgumentException,Microsoft.PowerShell.Commands.NewWinEventCommand'

adityapatwardhan · 2017-08-16T18:57:59Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+                $thrownError = $_
+            }
+
+            $thrownError.FullyQualifiedErrorId | Should Match $ExpectedFullyQualifiedErrorId


Use ShouldBeErrorId like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Diagnostics/New-WinEvent.Tests.ps1

Line 27 in 0b7451b

{ New-WinEvent -ProviderName NonExistingProvider -Id 0 } | ShouldBeErrorId 'System.ArgumentException,Microsoft.PowerShell.Commands.NewWinEventCommand'

adityapatwardhan · 2017-08-16T18:59:13Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+            }
+
+            $result | Should BeOfType 'Microsoft.PowerShell.Commands.ByteCollection'
+            $result[0].ToString() | Should Match $ExpectedResult


Should use MatchExactly like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1

Line 499 in 7b8c6e7

$ci[1].Name | Should MatchExactly $filenamePattern

adityapatwardhan · 2017-08-16T18:59:19Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+
+            if ($result.count -gt 1)
+            {
+                $result[1].ToString() | Should Match $ExpectedSecondResult


Should use MatchExactly like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1

Line 499 in 7b8c6e7

$ci[1].Name | Should MatchExactly $filenamePattern

adityapatwardhan · 2017-08-16T18:59:26Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+
+            $result.count | Should Be $Count
+            $result | Should BeOfType 'Microsoft.PowerShell.Commands.ByteCollection'
+            $result[0].ToString() | Should Match $ExpectedResult


Should use MatchExactly like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1

Line 499 in 7b8c6e7

$ci[1].Name | Should MatchExactly $filenamePattern

adityapatwardhan · 2017-08-16T18:59:38Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+            $errorThrown.FullyQualifiedErrorId | Should Match $ExpectedFullyQualifiedErrorId
+
+            $output.Length | Should Be 1
+            $output[0].ToString() | Should Match $inputText1


Should use MatchExactly like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1

Line 499 in 7b8c6e7

$ci[1].Name | Should MatchExactly $filenamePattern

adityapatwardhan · 2017-08-16T19:00:05Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

-            $result[1].ToString() | Should be "00000010   72 65 20 74 65 78 74                             re text         "
+            $result.Count | Should Be 3
+            $result[0].ToString() | Should be "00000000   4E 6F 77 20 69 73 20 74 68 65 20 77 69 6E 74 65  Now is the winte"
+            $result[1].ToString() | Should be "00000010   72 20 6F 66 20 6F 75 72 20 64 69 73 63 6F 6E 74  r of our discont"


Should use MatchExactly like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1

Line 499 in 7b8c6e7

$ci[1].Name | Should MatchExactly $filenamePattern

adityapatwardhan · 2017-08-16T19:00:06Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

-            $result[0].ToString() | Should be "00000000   54 68 69 73 20 69 73 20 61 20 62 69 74 20 6D 6F  This is a bit mo"
-            $result[1].ToString() | Should be "00000010   72 65 20 74 65 78 74                             re text         "
+            $result.Count | Should Be 3
+            $result[0].ToString() | Should be "00000000   4E 6F 77 20 69 73 20 74 68 65 20 77 69 6E 74 65  Now is the winte"


Should use MatchExactly like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1

Line 499 in 7b8c6e7

$ci[1].Name | Should MatchExactly $filenamePattern

adityapatwardhan · 2017-08-16T19:00:14Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+            $result.Count | Should Be 3
+            $result[0].ToString() | Should be "00000000   4E 6F 77 20 69 73 20 74 68 65 20 77 69 6E 74 65  Now is the winte"
+            $result[1].ToString() | Should be "00000010   72 20 6F 66 20 6F 75 72 20 64 69 73 63 6F 6E 74  r of our discont"
+            $result[2].ToString() | Should be "00000020   65 6E 74                                         ent             "


Should use MatchExactly like here:

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1

Line 499 in 7b8c6e7

$ci[1].Name | Should MatchExactly $filenamePattern

MiaRomero · 2017-08-16T21:11:03Z

Thanks @adityapatwardhan for the comments - fixed all the Match to MatchExactly.

adityapatwardhan

LGTM

msftclas added the cla-already-signed label May 17, 2017

MiaRomero requested review from Francisco-Gamino, JamesWTruher and lzybkr May 17, 2017 22:12

JamesWTruher reviewed May 18, 2017

View reviewed changes

mirichmo self-assigned this May 18, 2017

MiaRomero assigned MiaRomero and unassigned mirichmo May 18, 2017

lzybkr assigned mirichmo and unassigned MiaRomero May 18, 2017

lzybkr removed their request for review May 18, 2017 19:46

iSazonov reviewed May 25, 2017

View reviewed changes

Maria Romero added 2 commits June 6, 2017 11:56

update tests to include -TestCase paramater in It block

323ddda

Move test functions to appropriate context blocks

84a926b

MiaRomero force-pushed the formatHex-test-fix branch from 8ef74e2 to 84a926b Compare June 6, 2017 19:06

MiaRomero mentioned this pull request Jun 15, 2017

Fixed test to not create a file called 1 when run #4021

Closed

JamesWTruher reviewed Jun 30, 2017

View reviewed changes

combine skipTest conditions

8d89709

MiaRomero requested review from TravisEz13 and adityapatwardhan as code owners August 16, 2017 17:35

move skipTest to Describe block

d10847b

adityapatwardhan requested changes Aug 16, 2017

View reviewed changes

correct typo, change to MatchExactly

a0ca240

adityapatwardhan approved these changes Aug 16, 2017

View reviewed changes

mirichmo merged commit ea77b57 into PowerShell:master Aug 16, 2017


		Context "Continues to Process Valid Paths" {

		$skipTest = ([System.Management.Automation.Platform]::IsLinux -or [System.Management.Automation.Platform]::IsOSX)

Conversation

MiaRomero commented May 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lzybkr commented May 18, 2017

Uh oh!

mirichmo commented May 23, 2017

Uh oh!

mirichmo commented May 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MiaRomero commented Jun 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MiaRomero commented Aug 16, 2017

Uh oh!

adityapatwardhan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants