Addresses #3893 - Building PowerShell on Windows - Docs#3894
Closed
MarvTheRobot wants to merge 0 commit intoPowerShell:masterfrom
Closed
Addresses #3893 - Building PowerShell on Windows - Docs#3894MarvTheRobot wants to merge 0 commit intoPowerShell:masterfrom
MarvTheRobot wants to merge 0 commit intoPowerShell:masterfrom
Conversation
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Collaborator
|
@MarvTheRobot Thanks for the fix! Note that we are ready to migrate to 006195 version with #3887 So I believe we should use this version in docs and hold the PR until #3887 is merged. |
Contributor
Author
|
@iSazonov - agreed. |
Member
|
@MarvTheRobot #3887 is merged. Please update this PR so I can merge it.. |
Collaborator
Contributor
Author
|
@iSazonov ; thanks, I was about to ask if it had worked as build.psm1 is still using 2.0.0-preview1-005952. |
Contributor
Author
|
I'll re-raise this PR after I sort out my fork. I've been playing and broken it all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-core.md is out of date with regards .Net Core CLI version being installed by Start-PSBootStrap.
Updated document with correct version number and channel where required.