Make 'Start-PSBuild' and 'Start-PSPackage' accept a release tag argument#3921
Merged
daxian-dbw merged 4 commits intoPowerShell:masterfrom Jun 5, 2017
Merged
Make 'Start-PSBuild' and 'Start-PSPackage' accept a release tag argument#3921daxian-dbw merged 4 commits intoPowerShell:masterfrom
daxian-dbw merged 4 commits intoPowerShell:masterfrom
Conversation
lzybkr
reviewed
Jun 2, 2017
build.psm1
Outdated
| [string]$Version, | ||
|
|
||
| [Parameter(ParameterSetName = "ReleaseTag")] | ||
| [ValidatePattern("^v\d+\.\d+\.\d+-\w+\.\d+$")] |
Contributor
There was a problem hiding this comment.
The -\w+\.\d+ part should be optional - an official release won't have that part I think.
Member
Author
There was a problem hiding this comment.
True. Wil update the reg expression.
lzybkr
reviewed
Jun 2, 2017
|
|
||
| copy files FROM .\src\monad (old location of submodule) TO src/<project> folders | ||
| #> | ||
| function Copy-MappedFiles { |
Contributor
There was a problem hiding this comment.
Does this belong in a distinct change for another PR? Maybe also removing the json files and other functions like Get-Mappings?
Member
Author
Collaborator
There was a problem hiding this comment.
Such clean-ups will help us to move to MSBuild.
TravisEz13
approved these changes
Jun 3, 2017
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fix #3909
Issue Summary
Currently a release build depends on the release tag to be pushed. We need to break this dependency, so that creating the release tag can be made the last step of a release -- do it only if all preparation of the release is done.
Fix
Add a new parameter
-ReleaseTagtoStart-PSBuildandStart-PSPackageto allow a release tag to be passed in. When the release tag is specified at the command line, it will override the git commit id retrieved fromgit describe.Example
Follow-up work
Our VSO build script need to update to somehow accept a release tag value and pass it along when it's specified.