added 'semver' as core type accelerator for S.M.A.SemanticVersion#4142
added 'semver' as core type accelerator for S.M.A.SemanticVersion#4142daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
|
Appveyor temporary failed. |
|
Yeah, it seems one of the New-TimeSpan tests is failing. It must have already been broken when I merged to rebase. |
|
@PaulHigin currently |
|
@oising PowerShell core types are intended to be the absolute minimum needed in a constrained language interactive session. Can you tell us the scenario where this type is needed and why constrained language is required? |
|
@PaulHigin I guess I included it in core types for the same reasons you guys included |
|
@PaulHigin I think the rationale is that |
|
@daxian-dbw Yes, also good points. I took a cursory glance at the implementation and didn't see any red flags, but I'm also not privy to your criteria. |
|
Ok, I think this is reasonable. I'll review for security safety. Thanks. |
|
Filed #4221 to track adding tests for type accelerators in PowerShell. |
As per #3460
Added
[semver]as a core (safe to use in constrained language mode) type accelerator forSystem.Management.Automation.SemanticVersion.Individual accelerators are not currently being tested, so no unit tests were added or updated.